From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Nl67B-0003Tr-9v
	for qemu-devel@nongnu.org; Fri, 26 Feb 2010 14:44:45 -0500
Received: from [199.232.76.173] (port=54016 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Nl67A-0003Tb-MP
	for qemu-devel@nongnu.org; Fri, 26 Feb 2010 14:44:44 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <lcapitulino@redhat.com>) id 1Nl678-0006zK-De
	for qemu-devel@nongnu.org; Fri, 26 Feb 2010 14:44:43 -0500
Received: from mx20.gnu.org ([199.232.41.8]:41212)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <lcapitulino@redhat.com>)
	id 1Nl677-0006yy-Rh
	for qemu-devel@nongnu.org; Fri, 26 Feb 2010 14:44:42 -0500
Received: from mx1.redhat.com ([209.132.183.28])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <lcapitulino@redhat.com>) id 1Nl673-0003S6-Mi
	for qemu-devel@nongnu.org; Fri, 26 Feb 2010 14:44:38 -0500
Received: from int-mx01.intmail.prod.int.phx2.redhat.com
	(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o1QJiaZv023926
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 26 Feb 2010 14:44:36 -0500
Date: Fri, 26 Feb 2010 16:44:28 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH RFC 13/48] error: Make qemu_error() add a
	newline, strip it from arguments
Message-ID: <20100226164428.1a6bd890@redhat.com>
In-Reply-To: <1267034160-3517-14-git-send-email-armbru@redhat.com>
References: <1267034160-3517-1-git-send-email-armbru@redhat.com>
	<1267034160-3517-14-git-send-email-armbru@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org

On Wed, 24 Feb 2010 18:55:25 +0100
Markus Armbruster <armbru@redhat.com> wrote:

> This fixes a few error messages lacking a newline:
> net_handle_fd_param()'s "No file descriptor named %s found", and
> tap_open()'s "vnet_hdr=1 requested, but no kernel support for
> IFF_VNET_HDR available" (all three versions).
> 
> There's one place that passes arguments without newlines
> intentionally: load_vmstate().  Fix it up.

 I'm not a big fun of printing functions that add automatic newline,
specially in C. But I understand that you're doing this because you're
going to prefix some info to the printed string.

 In this case, you could rename the function to qemu_error_nl(). Or at
least document it properly in the function definition.