From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Nl67Y-0003YC-QC
	for qemu-devel@nongnu.org; Fri, 26 Feb 2010 14:45:08 -0500
Received: from [199.232.76.173] (port=54021 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Nl67X-0003Xw-T5
	for qemu-devel@nongnu.org; Fri, 26 Feb 2010 14:45:07 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <lcapitulino@redhat.com>) id 1Nl67V-00072u-9s
	for qemu-devel@nongnu.org; Fri, 26 Feb 2010 14:45:07 -0500
Received: from mx1.redhat.com ([209.132.183.28]:19320)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <lcapitulino@redhat.com>) id 1Nl67U-00072V-JN
	for qemu-devel@nongnu.org; Fri, 26 Feb 2010 14:45:04 -0500
Received: from int-mx08.intmail.prod.int.phx2.redhat.com
	(int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o1QJj2l4005096
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 26 Feb 2010 14:45:02 -0500
Date: Fri, 26 Feb 2010 16:44:53 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH RFC 15/48] error: Don't abuse qemu_error()
	for non-error in qdev_device_help()
Message-ID: <20100226164453.2c5e86ba@redhat.com>
In-Reply-To: <1267034160-3517-16-git-send-email-armbru@redhat.com>
References: <1267034160-3517-1-git-send-email-armbru@redhat.com>
	<1267034160-3517-16-git-send-email-armbru@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org

On Wed, 24 Feb 2010 18:55:27 +0100
Markus Armbruster <armbru@redhat.com> wrote:

> qdev_device_help() prints device information with qemu_error().  A
> later commit will make qemu_error() print additional stuff that is
> only appropriate for proper errors, and then this will break.  Use
> error_printf() instead.

 Aren't you abusing the error function just like the current code? Also,
I think that this information should be printed to stdout.