From: Paul Brook <paul@codesourcery.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/2] simplify global register save/restore
Date: Fri, 26 Feb 2010 18:32:01 +0000 [thread overview]
Message-ID: <201002261832.01836.paul@codesourcery.com> (raw)
In-Reply-To: <4B87C724.1030507@redhat.com>
> On 02/26/2010 12:30 PM, Paul Brook wrote:
> >> Since b567b38 (target-arm: remove T0 and T1, 2009-10-16) the only global
> >> register that is actually used is AREG0, so the complexity of
> >> hostregs_helper.h is unwarranted.
> >>
> >> Let's just say that env should be the only global register. AREG1 and
> >> AREG2 in principle could still be used to work around bad register
> >> allocation in GCC, so I'm leaving them in dyngen-exec.h.
> >
> > I think AREG[12] should be removed too. If we aren't saving them then
> > they can't be safely used.
>
> You could still use them for local register variables, but I can prepare
> a patch to remove them (unless you do that yourself).
I'm not sure what you mean by a "local register variable". If you're entirely
within TCG then the AREG defines aren't used anyway. If you're communicating
between TCG and C helpers then you need the cpu-exec.c save/restore.
I suspect you're thinking of TCG_AREG[12] in tcg-target.h. We should probably
remove those and allow the register allocator to reclaim those registers.
Paul
next prev parent reply other threads:[~2010-02-26 18:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-10 23:26 [Qemu-devel] [PATCH 0/2] simplify global register save/restore Paolo Bonzini
2010-02-10 23:26 ` [Qemu-devel] [PATCH 1/2] remove dead m68k global register definitions Paolo Bonzini
2010-02-10 23:26 ` [Qemu-devel] [PATCH 2/2] get rid of hostregs_helper.h Paolo Bonzini
2010-02-18 19:07 ` Blue Swirl
2010-02-18 20:25 ` [Qemu-devel] [PATCH v2 1/2] remove dead m68k definitions Paolo Bonzini
2010-02-18 20:25 ` [Qemu-devel] [PATCH v2 2/2] get rid of hostregs_helper.h Paolo Bonzini
2010-02-18 21:28 ` [Qemu-devel] " Blue Swirl
2010-02-25 11:40 ` Michael S. Tsirkin
2010-02-25 12:50 ` Paolo Bonzini
2010-02-25 13:04 ` Michael S. Tsirkin
2010-02-25 13:11 ` Paolo Bonzini
2010-02-13 17:58 ` [Qemu-devel] [PATCH 0/2] simplify global register save/restore Blue Swirl
2010-02-13 20:26 ` [Qemu-devel] " Paolo Bonzini
2010-02-13 20:57 ` Blue Swirl
2010-02-13 20:58 ` Paolo Bonzini
2010-02-26 11:30 ` [Qemu-devel] " Paul Brook
2010-02-26 13:05 ` Paolo Bonzini
2010-02-26 18:32 ` Paul Brook [this message]
2010-03-01 12:30 ` Paolo Bonzini
2010-03-01 14:02 ` Paul Brook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201002261832.01836.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).