qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Shahar Havivi <shaharh@redhat.com>
To: qemu-devel@nongnu.org
Cc: Dor Laor <dlaor@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] Restore terminal attributes for tty based monitor
Date: Fri, 26 Feb 2010 22:04:14 +0200	[thread overview]
Message-ID: <20100226200414.GA25277@redhat.com> (raw)
In-Reply-To: <20100226093456.GA17347@redhat.com>

Fix codding style
---
 qemu-char.c |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)

diff --git a/qemu-char.c b/qemu-char.c
index 4169492..4533887 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -1002,6 +1002,7 @@ static void tty_serial_init(int fd, int speed,
            speed, parity, data_bits, stop_bits);
 #endif
     tcgetattr (fd, &tty);
+    oldtty = tty;

 #define check_speed(val) if (speed <= val) { spd = B##val; break; }
     speed = speed * 10 / 11;
@@ -1173,6 +1174,11 @@ static int tty_serial_ioctl(CharDriverState *chr, int cmd, void *arg)
     return 0;
 }

+static void tty_exit(void)
+{
+    tcsetattr(0, TCSANOW, &oldtty);
+}
+
 static void qemu_chr_close_tty(CharDriverState *chr)
 {
     FDCharDriver *s = chr->opaque;
@@ -1207,6 +1213,9 @@ static CharDriverState *qemu_chr_open_tty(QemuOpts *opts)
     }
     chr->chr_ioctl = tty_serial_ioctl;
     chr->chr_close = qemu_chr_close_tty;
+    if (!term_atexit_done++) {
+        atexit(tty_exit);
+    }
     return chr;
 }
 #else  /* ! __linux__ && ! __sun__ */
--
1.6.3.3

  reply	other threads:[~2010-02-26 20:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-26  9:34 [Qemu-devel] [PATCH] Restore terminal attributes for tty based monitor Shahar Havivi
2010-02-26 20:04 ` Shahar Havivi [this message]
2010-02-26 22:19   ` David S. Ahern
2010-02-27  8:41     ` Shahar Havivi
2010-02-27 16:20       ` David S. Ahern
2010-03-01 12:19         ` Shahar Havivi
2010-03-09 15:02 ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100226200414.GA25277@redhat.com \
    --to=shaharh@redhat.com \
    --cc=dlaor@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).