From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NlIFM-000638-5o
	for qemu-devel@nongnu.org; Sat, 27 Feb 2010 03:42:00 -0500
Received: from [199.232.76.173] (port=58464 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NlIFL-000630-OS
	for qemu-devel@nongnu.org; Sat, 27 Feb 2010 03:41:59 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <shaharh@redhat.com>) id 1NlIFK-0002Pt-7Q
	for qemu-devel@nongnu.org; Sat, 27 Feb 2010 03:41:59 -0500
Received: from mx1.redhat.com ([209.132.183.28]:13663)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <shaharh@redhat.com>) id 1NlIFJ-0002Pm-RT
	for qemu-devel@nongnu.org; Sat, 27 Feb 2010 03:41:58 -0500
Date: Sat, 27 Feb 2010 10:41:44 +0200
From: Shahar Havivi <shaharh@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] Restore terminal attributes for tty based
	monitor
Message-ID: <20100227084143.GA3078@redhat.com>
References: <20100226093456.GA17347@redhat.com>
	<20100226200414.GA25277@redhat.com> <4B8848E7.4010401@cisco.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4B8848E7.4010401@cisco.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "David S. Ahern" <daahern@cisco.com>
Cc: Dor Laor <dlaor@redhat.com>, qemu-devel@nongnu.org

On Fri, Feb 26, 2010 at 03:19:19PM -0700, David S. Ahern wrote:
> Date: Fri, 26 Feb 2010 15:19:19 -0700
> From: "David S. Ahern" <daahern@cisco.com>
> To: Shahar Havivi <shaharh@redhat.com>
> CC: qemu-devel@nongnu.org, Dor Laor <dlaor@redhat.com>
> Subject: Re: [Qemu-devel] [PATCH] Restore terminal attributes for tty based
>  monitor
> 
> 
> 
> 
> 
> On 02/26/2010 01:04 PM, Shahar Havivi wrote:
> > Fix codding style
> > ---
> >  qemu-char.c |    9 +++++++++
> >  1 files changed, 9 insertions(+), 0 deletions(-)
> > 
> > diff --git a/qemu-char.c b/qemu-char.c
> > index 4169492..4533887 100644
> > --- a/qemu-char.c
> > +++ b/qemu-char.c
> > @@ -1002,6 +1002,7 @@ static void tty_serial_init(int fd, int speed,
> >             speed, parity, data_bits, stop_bits);
> >  #endif
> >      tcgetattr (fd, &tty);
> > +    oldtty = tty;
> > 
> >  #define check_speed(val) if (speed <= val) { spd = B##val; break; }
> >      speed = speed * 10 / 11;
> > @@ -1173,6 +1174,11 @@ static int tty_serial_ioctl(CharDriverState *chr, int cmd, void *arg)
> >      return 0;
> >  }
> > 
> > +static void tty_exit(void)
> > +{
> > +    tcsetattr(0, TCSANOW, &oldtty);
> > +}
> > +
> >  static void qemu_chr_close_tty(CharDriverState *chr)
> >  {
> >      FDCharDriver *s = chr->opaque;
> > @@ -1207,6 +1213,9 @@ static CharDriverState *qemu_chr_open_tty(QemuOpts *opts)
> >      }
> >      chr->chr_ioctl = tty_serial_ioctl;
> >      chr->chr_close = qemu_chr_close_tty;
> > +    if (!term_atexit_done++) {
> > +        atexit(tty_exit);
> > +    }
> >      return chr;
> >  }
> >  #else  /* ! __linux__ && ! __sun__ */
> > --
> > 1.6.3.3
> > 
> 
> If qemu is invoked with both stdio and one or more host tty's only the
> last one referenced is reset one exit. Also, shouldn't the attributes be
> reset when the device is closed as opposed to exit? ie., a device
> connected to a tty chardev is removed via the monitor.
> 
> David
stdio have the same handling code:
http://git.savannah.gnu.org/cgit/qemu.git/tree/qemu-char.c#n738

Shahar