From: Aurelien Jarno <aurelien@aurel32.net>
To: Liu Yu <yu.liu@freescale.com>
Cc: qemu-devel@nongnu.org, hollis@penguinppc.org
Subject: Re: [Qemu-devel] [PATCH 1/2] powerpc/booke: move fdt loading to rom infrastructure
Date: Sat, 27 Feb 2010 19:49:23 +0100 [thread overview]
Message-ID: <20100227184923.GW10348@hall.aurel32.net> (raw)
In-Reply-To: <20100227153302.GH10291@volta.aurel32.net>
On Sat, Feb 27, 2010 at 04:33:02PM +0100, Aurelien Jarno wrote:
> On Tue, Feb 02, 2010 at 04:49:02PM +0800, Liu Yu wrote:
> > It's convinent to use rom to checking overlap, to reset etc.
> > And uImage and ramdisk loading has already moved to it.
> >
> > Also, after we add fdt to rom, free it.
>
> This does not build if CONFIG_FDT is not set:
>
> | CC ppc-softmmu/ppc440_bamboo.o
> | /home/aurel32/git/qemu/hw/ppc440_bamboo.c: In function 'bamboo_load_device_tree':
> | /home/aurel32/git/qemu/hw/ppc440_bamboo.c:86: error: 'ret' undeclared (first use in this function)
> | /home/aurel32/git/qemu/hw/ppc440_bamboo.c:86: error: (Each undeclared identifier is reported only once
> | /home/aurel32/git/qemu/hw/ppc440_bamboo.c:86: error: for each function it appears in.)
> | cc1: warnings being treated as errors
> | /home/aurel32/git/qemu/hw/ppc440_bamboo.c:36: error: unused variable 'fdt'
> | make[1]: *** [ppc440_bamboo.o] Error 1
> | make: *** [subdir-ppc-softmmu] Error 2
>
As I have pushed the patch by mistake to the git tree, and it is mostly
ok, I have committed a patch to fix the above issue.
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
prev parent reply other threads:[~2010-02-27 18:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-02 8:49 [Qemu-devel] [PATCH 1/2] powerpc/booke: move fdt loading to rom infrastructure Liu Yu
2010-02-02 8:49 ` [Qemu-devel] [PATCH 2/2] powerpc/e500: adjust fdt and ramdisk loading addr Liu Yu
2010-02-27 15:33 ` [Qemu-devel] [PATCH 1/2] powerpc/booke: move fdt loading to rom infrastructure Aurelien Jarno
2010-02-27 18:49 ` Aurelien Jarno [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100227184923.GW10348@hall.aurel32.net \
--to=aurelien@aurel32.net \
--cc=hollis@penguinppc.org \
--cc=qemu-devel@nongnu.org \
--cc=yu.liu@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).