From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Blue Swirl <blauwirbel@gmail.com>
Subject: Re: [Qemu-devel] [PATCH] pc: madvise(MADV_DONTNEED) memory on reset
Date: Sun, 28 Feb 2010 00:57:40 +0000 [thread overview]
Message-ID: <201002280057.41164.paul@codesourcery.com> (raw)
In-Reply-To: <4B85A2C7.6040406@codemonkey.ws>
> > I think it would be much cleaner to make the madvise() calls from
> > exec.c, now you are duplicating some of the functionality there. The
> > calls could be controlled by a global variable (set only in pc.c) so
> > non-PC architectures would not be disturbed.
>
> One thing we could do (that I think has other uses) is to add a context
> parameter to qemu_ram_alloc(). We could start with a simple flag of
> something like QRAM_RAM and QRAM_ROM. QRAM_RAM would get automatically
> madvise()'d on reset.
>
> But that said, does anyone know of an architecture where this type of
> reset would be a problem? Would it be a problem on sparc?
I think it's simplest to just say that qemu_system_reset is a full hard reset.
We already reload ROM images, etc.
Paul
next prev parent reply other threads:[~2010-02-28 0:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-24 19:10 [Qemu-devel] [PATCH] pc: madvise(MADV_DONTNEED) memory on reset Anthony Liguori
2010-02-24 20:59 ` Blue Swirl
2010-02-24 22:05 ` Anthony Liguori
2010-02-28 0:57 ` Paul Brook [this message]
2010-02-24 23:56 ` Samuel Thibault
2010-02-28 9:13 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201002280057.41164.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).