From: Aurelien Jarno <aurelien@aurel32.net>
To: Johan Bengtsson <teofrastius@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] * Fixed problem with IT AL.
Date: Sun, 28 Feb 2010 19:58:29 +0100	[thread overview]
Message-ID: <20100228185829.GS10291@volta.aurel32.net> (raw)
In-Reply-To: <1265730227-21926-2-git-send-email-teofrastius@gmail.com>
The patch looks ok. Can you please resend it with a Signed-of-by: line,
and maybe a better subject mentioning ARM?
On Tue, Feb 09, 2010 at 04:43:47PM +0100, Johan Bengtsson wrote:
> ---
>  target-arm/translate.c |    8 +++++---
>  1 files changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/target-arm/translate.c b/target-arm/translate.c
> index 786c329..554583d 100644
> --- a/target-arm/translate.c
> +++ b/target-arm/translate.c
> @@ -8328,9 +8328,11 @@ static void disas_thumb_insn(CPUState *env, DisasContext *s)
>  
>      if (s->condexec_mask) {
>          cond = s->condexec_cond;
> -        s->condlabel = gen_new_label();
> -        gen_test_cc(cond ^ 1, s->condlabel);
> -        s->condjmp = 1;
> +        if (cond != 0x0e) {     /* Skip conditional when condition is AL. */
> +          s->condlabel = gen_new_label();
> +          gen_test_cc(cond ^ 1, s->condlabel);
> +          s->condjmp = 1;
> +        }
>      }
>  
>      insn = lduw_code(s->pc);
> -- 
> 1.6.3.3
> 
> 
> 
> 
-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net
     prev parent reply	other threads:[~2010-02-28 18:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-09 15:43 [Qemu-devel] [PATCH] Fixed problem with IT AL Johan Bengtsson
2010-02-09 15:43 ` [Qemu-devel] [PATCH] * " Johan Bengtsson
2010-02-28 18:58   ` Aurelien Jarno [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox
  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):
  git send-email \
    --in-reply-to=20100228185829.GS10291@volta.aurel32.net \
    --to=aurelien@aurel32.net \
    --cc=qemu-devel@nongnu.org \
    --cc=teofrastius@gmail.com \
    /path/to/YOUR_REPLY
  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
  Be sure your reply has a Subject: header at the top and a blank line
  before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).