* [Qemu-devel] [PATCH] Restore terminal attributes for tty based monitor @ 2010-02-26 9:34 Shahar Havivi 2010-02-26 20:04 ` Shahar Havivi 2010-03-09 15:02 ` Anthony Liguori 0 siblings, 2 replies; 7+ messages in thread From: Shahar Havivi @ 2010-02-26 9:34 UTC (permalink / raw) To: qemu-devel; +Cc: Dor Laor Patch http://permalink.gmane.org/gmane.comp.emulators.qemu/63472 handle close when using tty devices (like /dev/ttyS0), yet tty based monitor are not restoring terminal attributes (as done with stdio based monitor), when closing qemu after that command: $ qemu -monitor /dev/tty the terminal is not responding until you write reset (blindly), this patch fix it --- qemu-char.c | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index 4169492..7aae21b 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -1002,6 +1002,7 @@ static void tty_serial_init(int fd, int speed, speed, parity, data_bits, stop_bits); #endif tcgetattr (fd, &tty); + oldtty = tty; #define check_speed(val) if (speed <= val) { spd = B##val; break; } speed = speed * 10 / 11; @@ -1173,6 +1174,11 @@ static int tty_serial_ioctl(CharDriverState *chr, int cmd, void *arg) return 0; } +static void tty_exit(void) +{ + tcsetattr(0, TCSANOW, &oldtty); +} + static void qemu_chr_close_tty(CharDriverState *chr) { FDCharDriver *s = chr->opaque; @@ -1207,6 +1213,8 @@ static CharDriverState *qemu_chr_open_tty(QemuOpts *opts) } chr->chr_ioctl = tty_serial_ioctl; chr->chr_close = qemu_chr_close_tty; + if (!term_atexit_done++) + atexit(tty_exit); return chr; } #else /* ! __linux__ && ! __sun__ */ -- 1.6.3.3 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH] Restore terminal attributes for tty based monitor 2010-02-26 9:34 [Qemu-devel] [PATCH] Restore terminal attributes for tty based monitor Shahar Havivi @ 2010-02-26 20:04 ` Shahar Havivi 2010-02-26 22:19 ` David S. Ahern 2010-03-09 15:02 ` Anthony Liguori 1 sibling, 1 reply; 7+ messages in thread From: Shahar Havivi @ 2010-02-26 20:04 UTC (permalink / raw) To: qemu-devel; +Cc: Dor Laor Fix codding style --- qemu-char.c | 9 +++++++++ 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index 4169492..4533887 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -1002,6 +1002,7 @@ static void tty_serial_init(int fd, int speed, speed, parity, data_bits, stop_bits); #endif tcgetattr (fd, &tty); + oldtty = tty; #define check_speed(val) if (speed <= val) { spd = B##val; break; } speed = speed * 10 / 11; @@ -1173,6 +1174,11 @@ static int tty_serial_ioctl(CharDriverState *chr, int cmd, void *arg) return 0; } +static void tty_exit(void) +{ + tcsetattr(0, TCSANOW, &oldtty); +} + static void qemu_chr_close_tty(CharDriverState *chr) { FDCharDriver *s = chr->opaque; @@ -1207,6 +1213,9 @@ static CharDriverState *qemu_chr_open_tty(QemuOpts *opts) } chr->chr_ioctl = tty_serial_ioctl; chr->chr_close = qemu_chr_close_tty; + if (!term_atexit_done++) { + atexit(tty_exit); + } return chr; } #else /* ! __linux__ && ! __sun__ */ -- 1.6.3.3 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH] Restore terminal attributes for tty based monitor 2010-02-26 20:04 ` Shahar Havivi @ 2010-02-26 22:19 ` David S. Ahern 2010-02-27 8:41 ` Shahar Havivi 0 siblings, 1 reply; 7+ messages in thread From: David S. Ahern @ 2010-02-26 22:19 UTC (permalink / raw) To: Shahar Havivi; +Cc: Dor Laor, qemu-devel On 02/26/2010 01:04 PM, Shahar Havivi wrote: > Fix codding style > --- > qemu-char.c | 9 +++++++++ > 1 files changed, 9 insertions(+), 0 deletions(-) > > diff --git a/qemu-char.c b/qemu-char.c > index 4169492..4533887 100644 > --- a/qemu-char.c > +++ b/qemu-char.c > @@ -1002,6 +1002,7 @@ static void tty_serial_init(int fd, int speed, > speed, parity, data_bits, stop_bits); > #endif > tcgetattr (fd, &tty); > + oldtty = tty; > > #define check_speed(val) if (speed <= val) { spd = B##val; break; } > speed = speed * 10 / 11; > @@ -1173,6 +1174,11 @@ static int tty_serial_ioctl(CharDriverState *chr, int cmd, void *arg) > return 0; > } > > +static void tty_exit(void) > +{ > + tcsetattr(0, TCSANOW, &oldtty); > +} > + > static void qemu_chr_close_tty(CharDriverState *chr) > { > FDCharDriver *s = chr->opaque; > @@ -1207,6 +1213,9 @@ static CharDriverState *qemu_chr_open_tty(QemuOpts *opts) > } > chr->chr_ioctl = tty_serial_ioctl; > chr->chr_close = qemu_chr_close_tty; > + if (!term_atexit_done++) { > + atexit(tty_exit); > + } > return chr; > } > #else /* ! __linux__ && ! __sun__ */ > -- > 1.6.3.3 > If qemu is invoked with both stdio and one or more host tty's only the last one referenced is reset one exit. Also, shouldn't the attributes be reset when the device is closed as opposed to exit? ie., a device connected to a tty chardev is removed via the monitor. David ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH] Restore terminal attributes for tty based monitor 2010-02-26 22:19 ` David S. Ahern @ 2010-02-27 8:41 ` Shahar Havivi 2010-02-27 16:20 ` David S. Ahern 0 siblings, 1 reply; 7+ messages in thread From: Shahar Havivi @ 2010-02-27 8:41 UTC (permalink / raw) To: David S. Ahern; +Cc: Dor Laor, qemu-devel On Fri, Feb 26, 2010 at 03:19:19PM -0700, David S. Ahern wrote: > Date: Fri, 26 Feb 2010 15:19:19 -0700 > From: "David S. Ahern" <daahern@cisco.com> > To: Shahar Havivi <shaharh@redhat.com> > CC: qemu-devel@nongnu.org, Dor Laor <dlaor@redhat.com> > Subject: Re: [Qemu-devel] [PATCH] Restore terminal attributes for tty based > monitor > > > > > > On 02/26/2010 01:04 PM, Shahar Havivi wrote: > > Fix codding style > > --- > > qemu-char.c | 9 +++++++++ > > 1 files changed, 9 insertions(+), 0 deletions(-) > > > > diff --git a/qemu-char.c b/qemu-char.c > > index 4169492..4533887 100644 > > --- a/qemu-char.c > > +++ b/qemu-char.c > > @@ -1002,6 +1002,7 @@ static void tty_serial_init(int fd, int speed, > > speed, parity, data_bits, stop_bits); > > #endif > > tcgetattr (fd, &tty); > > + oldtty = tty; > > > > #define check_speed(val) if (speed <= val) { spd = B##val; break; } > > speed = speed * 10 / 11; > > @@ -1173,6 +1174,11 @@ static int tty_serial_ioctl(CharDriverState *chr, int cmd, void *arg) > > return 0; > > } > > > > +static void tty_exit(void) > > +{ > > + tcsetattr(0, TCSANOW, &oldtty); > > +} > > + > > static void qemu_chr_close_tty(CharDriverState *chr) > > { > > FDCharDriver *s = chr->opaque; > > @@ -1207,6 +1213,9 @@ static CharDriverState *qemu_chr_open_tty(QemuOpts *opts) > > } > > chr->chr_ioctl = tty_serial_ioctl; > > chr->chr_close = qemu_chr_close_tty; > > + if (!term_atexit_done++) { > > + atexit(tty_exit); > > + } > > return chr; > > } > > #else /* ! __linux__ && ! __sun__ */ > > -- > > 1.6.3.3 > > > > If qemu is invoked with both stdio and one or more host tty's only the > last one referenced is reset one exit. Also, shouldn't the attributes be > reset when the device is closed as opposed to exit? ie., a device > connected to a tty chardev is removed via the monitor. > > David stdio have the same handling code: http://git.savannah.gnu.org/cgit/qemu.git/tree/qemu-char.c#n738 Shahar ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH] Restore terminal attributes for tty based monitor 2010-02-27 8:41 ` Shahar Havivi @ 2010-02-27 16:20 ` David S. Ahern 2010-03-01 12:19 ` Shahar Havivi 0 siblings, 1 reply; 7+ messages in thread From: David S. Ahern @ 2010-02-27 16:20 UTC (permalink / raw) To: Shahar Havivi; +Cc: Dor Laor, qemu-devel On 02/27/2010 01:41 AM, Shahar Havivi wrote: > On Fri, Feb 26, 2010 at 03:19:19PM -0700, David S. Ahern wrote: >> Date: Fri, 26 Feb 2010 15:19:19 -0700 >> From: "David S. Ahern" <daahern@cisco.com> >> To: Shahar Havivi <shaharh@redhat.com> >> CC: qemu-devel@nongnu.org, Dor Laor <dlaor@redhat.com> >> Subject: Re: [Qemu-devel] [PATCH] Restore terminal attributes for tty based >> monitor >> >> >> >> >> >> On 02/26/2010 01:04 PM, Shahar Havivi wrote: >>> Fix codding style >>> --- >>> qemu-char.c | 9 +++++++++ >>> 1 files changed, 9 insertions(+), 0 deletions(-) >>> >>> diff --git a/qemu-char.c b/qemu-char.c >>> index 4169492..4533887 100644 >>> --- a/qemu-char.c >>> +++ b/qemu-char.c >>> @@ -1002,6 +1002,7 @@ static void tty_serial_init(int fd, int speed, >>> speed, parity, data_bits, stop_bits); >>> #endif >>> tcgetattr (fd, &tty); >>> + oldtty = tty; >>> >>> #define check_speed(val) if (speed <= val) { spd = B##val; break; } >>> speed = speed * 10 / 11; >>> @@ -1173,6 +1174,11 @@ static int tty_serial_ioctl(CharDriverState *chr, int cmd, void *arg) >>> return 0; >>> } >>> >>> +static void tty_exit(void) >>> +{ >>> + tcsetattr(0, TCSANOW, &oldtty); >>> +} >>> + >>> static void qemu_chr_close_tty(CharDriverState *chr) >>> { >>> FDCharDriver *s = chr->opaque; >>> @@ -1207,6 +1213,9 @@ static CharDriverState *qemu_chr_open_tty(QemuOpts *opts) >>> } >>> chr->chr_ioctl = tty_serial_ioctl; >>> chr->chr_close = qemu_chr_close_tty; >>> + if (!term_atexit_done++) { >>> + atexit(tty_exit); >>> + } >>> return chr; >>> } >>> #else /* ! __linux__ && ! __sun__ */ >>> -- >>> 1.6.3.3 >>> >> >> If qemu is invoked with both stdio and one or more host tty's only the >> last one referenced is reset one exit. Also, shouldn't the attributes be >> reset when the device is closed as opposed to exit? ie., a device >> connected to a tty chardev is removed via the monitor. >> >> David > stdio have the same handling code: > http://git.savannah.gnu.org/cgit/qemu.git/tree/qemu-char.c#n738 > > Shahar Right now stdio is the only user of the oldtty global, so it holds the atributes for stdio. If you reuse the variable you are setting the tty (ttyN or ttySN) to the attributes retrieved from stdin - assuming it was even used. I think you want to save the attributes for the terminal that is in use and reset that terminal on close / exit. David ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH] Restore terminal attributes for tty based monitor 2010-02-27 16:20 ` David S. Ahern @ 2010-03-01 12:19 ` Shahar Havivi 0 siblings, 0 replies; 7+ messages in thread From: Shahar Havivi @ 2010-03-01 12:19 UTC (permalink / raw) To: David S. Ahern; +Cc: Dor Laor, qemu-devel On Sat, Feb 27, 2010 at 09:20:28AM -0700, David S. Ahern wrote: > Date: Sat, 27 Feb 2010 09:20:28 -0700 > From: "David S. Ahern" <daahern@cisco.com> > To: Shahar Havivi <shaharh@redhat.com> > CC: qemu-devel@nongnu.org, Dor Laor <dlaor@redhat.com> > Subject: Re: [Qemu-devel] [PATCH] Restore terminal attributes for tty based > monitor > > > > > > On 02/27/2010 01:41 AM, Shahar Havivi wrote: > > On Fri, Feb 26, 2010 at 03:19:19PM -0700, David S. Ahern wrote: > >> Date: Fri, 26 Feb 2010 15:19:19 -0700 > >> From: "David S. Ahern" <daahern@cisco.com> > >> To: Shahar Havivi <shaharh@redhat.com> > >> CC: qemu-devel@nongnu.org, Dor Laor <dlaor@redhat.com> > >> Subject: Re: [Qemu-devel] [PATCH] Restore terminal attributes for tty based > >> monitor > >> > >> > >> > >> > >> > >> On 02/26/2010 01:04 PM, Shahar Havivi wrote: > >>> Fix codding style > >>> --- > >>> qemu-char.c | 9 +++++++++ > >>> 1 files changed, 9 insertions(+), 0 deletions(-) > >>> > >>> diff --git a/qemu-char.c b/qemu-char.c > >>> index 4169492..4533887 100644 > >>> --- a/qemu-char.c > >>> +++ b/qemu-char.c > >>> @@ -1002,6 +1002,7 @@ static void tty_serial_init(int fd, int speed, > >>> speed, parity, data_bits, stop_bits); > >>> #endif > >>> tcgetattr (fd, &tty); > >>> + oldtty = tty; > >>> > >>> #define check_speed(val) if (speed <= val) { spd = B##val; break; } > >>> speed = speed * 10 / 11; > >>> @@ -1173,6 +1174,11 @@ static int tty_serial_ioctl(CharDriverState *chr, int cmd, void *arg) > >>> return 0; > >>> } > >>> > >>> +static void tty_exit(void) > >>> +{ > >>> + tcsetattr(0, TCSANOW, &oldtty); > >>> +} > >>> + > >>> static void qemu_chr_close_tty(CharDriverState *chr) > >>> { > >>> FDCharDriver *s = chr->opaque; > >>> @@ -1207,6 +1213,9 @@ static CharDriverState *qemu_chr_open_tty(QemuOpts *opts) > >>> } > >>> chr->chr_ioctl = tty_serial_ioctl; > >>> chr->chr_close = qemu_chr_close_tty; > >>> + if (!term_atexit_done++) { > >>> + atexit(tty_exit); > >>> + } > >>> return chr; > >>> } > >>> #else /* ! __linux__ && ! __sun__ */ > >>> -- > >>> 1.6.3.3 > >>> > >> > >> If qemu is invoked with both stdio and one or more host tty's only the > >> last one referenced is reset one exit. Also, shouldn't the attributes be > >> reset when the device is closed as opposed to exit? ie., a device > >> connected to a tty chardev is removed via the monitor. > >> > >> David > > stdio have the same handling code: > > http://git.savannah.gnu.org/cgit/qemu.git/tree/qemu-char.c#n738 > > > > Shahar > > Right now stdio is the only user of the oldtty global, so it holds the > atributes for stdio. If you reuse the variable you are setting the tty > (ttyN or ttySN) to the attributes retrieved from stdin - assuming it was > even used. > > I think you want to save the attributes for the terminal that is in use > and reset that terminal on close / exit. The oldtty global can be reuse, as far for the ttnN and ttySN you right, it may be wrong for them, I will recheck. Shahar. > > David ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH] Restore terminal attributes for tty based monitor 2010-02-26 9:34 [Qemu-devel] [PATCH] Restore terminal attributes for tty based monitor Shahar Havivi 2010-02-26 20:04 ` Shahar Havivi @ 2010-03-09 15:02 ` Anthony Liguori 1 sibling, 0 replies; 7+ messages in thread From: Anthony Liguori @ 2010-03-09 15:02 UTC (permalink / raw) To: Shahar Havivi; +Cc: Dor Laor, qemu-devel On 02/26/2010 03:34 AM, Shahar Havivi wrote: > Patch http://permalink.gmane.org/gmane.comp.emulators.qemu/63472 handle > close when using tty devices (like /dev/ttyS0), > yet tty based monitor are not restoring terminal attributes (as done > with stdio based monitor), when closing qemu after that command: > $ qemu -monitor /dev/tty > the terminal is not responding until you write reset (blindly), > this patch fix it > Applied. Thanks. Regards, Anthony Liguori > --- > qemu-char.c | 8 ++++++++ > 1 files changed, 8 insertions(+), 0 deletions(-) > > diff --git a/qemu-char.c b/qemu-char.c > index 4169492..7aae21b 100644 > --- a/qemu-char.c > +++ b/qemu-char.c > @@ -1002,6 +1002,7 @@ static void tty_serial_init(int fd, int speed, > speed, parity, data_bits, stop_bits); > #endif > tcgetattr (fd,&tty); > + oldtty = tty; > > #define check_speed(val) if (speed<= val) { spd = B##val; break; } > speed = speed * 10 / 11; > @@ -1173,6 +1174,11 @@ static int tty_serial_ioctl(CharDriverState *chr, int cmd, void *arg) > return 0; > } > > +static void tty_exit(void) > +{ > + tcsetattr(0, TCSANOW,&oldtty); > +} > + > static void qemu_chr_close_tty(CharDriverState *chr) > { > FDCharDriver *s = chr->opaque; > @@ -1207,6 +1213,8 @@ static CharDriverState *qemu_chr_open_tty(QemuOpts *opts) > } > chr->chr_ioctl = tty_serial_ioctl; > chr->chr_close = qemu_chr_close_tty; > + if (!term_atexit_done++) > + atexit(tty_exit); > return chr; > } > #else /* ! __linux__&& ! __sun__ */ > -- > 1.6.3.3 > > > > > ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2010-03-09 15:02 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2010-02-26 9:34 [Qemu-devel] [PATCH] Restore terminal attributes for tty based monitor Shahar Havivi 2010-02-26 20:04 ` Shahar Havivi 2010-02-26 22:19 ` David S. Ahern 2010-02-27 8:41 ` Shahar Havivi 2010-02-27 16:20 ` David S. Ahern 2010-03-01 12:19 ` Shahar Havivi 2010-03-09 15:02 ` Anthony Liguori
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).