From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NmPyZ-0005Fw-JM for qemu-devel@nongnu.org; Tue, 02 Mar 2010 06:09:19 -0500 Received: from [199.232.76.173] (port=33327 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NmPyX-0005En-3k for qemu-devel@nongnu.org; Tue, 02 Mar 2010 06:09:17 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NmPyU-0002KZ-4t for qemu-devel@nongnu.org; Tue, 02 Mar 2010 06:09:16 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38942) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NmPyT-0002KV-OJ for qemu-devel@nongnu.org; Tue, 02 Mar 2010 06:09:14 -0500 Date: Tue, 2 Mar 2010 13:05:49 +0200 From: "Michael S. Tsirkin" Subject: Re: [Qemu-devel] [PATCH] VirtIO: Fix QEMU crash during Windows PNP tests Message-ID: <20100302110549.GA6064@redhat.com> References: <1252935086-8856-1-git-send-email-yvugenfi@redhat.com> <20100301112637.GH16909@redhat.com> <20100302100957.GA6150@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: Yan Vugenfirer , "qemu-devel@nongnu.org Developers" , Gleb Natapov On Tue, Mar 02, 2010 at 12:03:15PM +0100, Alexander Graf wrote: > > On 02.03.2010, at 11:09, Michael S. Tsirkin wrote: > > > On Mon, Mar 01, 2010 at 01:26:37PM +0200, Gleb Natapov wrote: > >> On Mon, Mar 01, 2010 at 12:14:43PM +0100, Alexander Graf wrote: > >>> > >>> On 14.09.2009, at 15:31, Yan Vugenfirer wrote: > >>> > >>>> Signed-off-by: Yan Vugenfirer > >>>> > >>>> --- > >>>> hw/virtio-pci.c | 14 ++++++++++++-- > >>>> 1 files changed, 12 insertions(+), 2 deletions(-) > >>>> > >>>> diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c > >>>> index f812ab7..a0a22c4 100644 > >>>> --- a/hw/virtio-pci.c > >>>> +++ b/hw/virtio-pci.c > >>>> @@ -364,8 +364,17 @@ static void virtio_map(PCIDevice *pci_dev, int region_num, > >>>> static void virtio_write_config(PCIDevice *pci_dev, uint32_t address, > >>>> uint32_t val, int len) > >>>> { > >>>> + VirtIOPCIProxy *proxy = DO_UPCAST(VirtIOPCIProxy, pci_dev, pci_dev); > >>>> + > >>>> + if (PCI_COMMAND == address) { > >>>> + if (!(val & PCI_COMMAND_MASTER)) { > >>>> + proxy->vdev->status &= ~VIRTIO_CONFIG_S_DRIVER_OK; > >>> > >>> This part breaks PCI hotplug with Linux guests. > >>> > >>> What happens is the following: > >> Looks like something is broken even without this patch. > >> > >>> > >>> (qemu) pci_add auto nic model=virtio,vlan=0 > >>> - Virtio dev 1 -> write config (0) > >>> - Virtio dev 1 -> write config (0x3) > >>> - Virtio dev 1 -> set status explicitly to OK > >> Why Linux doesn't enable bus mastering on this device? > > > > I fixed this, and Rusty said he has applied the patch, > > but it seems the patch got lost later: > > > > http://lkml.org/lkml/2009/11/29/73 > > > > Alexander, could you please check whether applying > > this patch fixes hotplug for you? > > If yes I will queue it up for 2.6.34. > > So we're looking at a guest bug? Donnu. Does it work with the patch applied? > It's still a qemu regression then. This configuration used to work > with 0.10. There should at least be a feature bit from the guest > saying "I'm good with bus mastering", so we can enable the check only > for those. > Alex