From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nmn9x-0006AR-10 for qemu-devel@nongnu.org; Wed, 03 Mar 2010 06:54:37 -0500 Received: from [199.232.76.173] (port=52142 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nmn9v-0006AD-Rr for qemu-devel@nongnu.org; Wed, 03 Mar 2010 06:54:35 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1Nmn9u-0004j1-Bv for qemu-devel@nongnu.org; Wed, 03 Mar 2010 06:54:35 -0500 Received: from mx1.redhat.com ([209.132.183.28]:14308) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Nmn9t-0004ix-Vk for qemu-devel@nongnu.org; Wed, 03 Mar 2010 06:54:34 -0500 Date: Wed, 3 Mar 2010 13:51:11 +0200 From: "Michael S. Tsirkin" Message-ID: <20100303115111.GD15278@redhat.com> References: <4B7821AC.6080400@mail.berlios.de> <1266164189-21062-1-git-send-email-weil@mail.berlios.de> <1266164189-21062-2-git-send-email-weil@mail.berlios.de> <1266164189-21062-3-git-send-email-weil@mail.berlios.de> <1266164189-21062-4-git-send-email-weil@mail.berlios.de> <1266164189-21062-5-git-send-email-weil@mail.berlios.de> <20100221170021.GA5185@redhat.com> <4B81A0E1.5030300@mail.berlios.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4B81A0E1.5030300@mail.berlios.de> Subject: [Qemu-devel] Re: [PATCH 05/20] eepro100: Add all supported devices to pci.c List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil , kraxel@redhat.com Cc: QEMU Developers On Sun, Feb 21, 2010 at 10:08:49PM +0100, Stefan Weil wrote: > Michael S. Tsirkin schrieb: > > On Sun, Feb 14, 2010 at 05:16:14PM +0100, Stefan Weil wrote: > > > >> All eepro100 devices work with drivers which > >> only use basic features. > >> > >> They were tested with gpxe boot. > >> > >> Signed-off-by: Stefan Weil > >> --- > >> hw/pci.c | 18 ++++++++++++++++++ > >> 1 files changed, 18 insertions(+), 0 deletions(-) > >> > >> diff --git a/hw/pci.c b/hw/pci.c > >> index eb2043e..1ba3f92 100644 > >> --- a/hw/pci.c > >> +++ b/hw/pci.c > >> @@ -1436,9 +1436,18 @@ void do_pci_info(Monitor *mon, QObject **ret_data) > >> > >> static const char * const pci_nic_models[] = { > >> "ne2k_pci", > >> + "i82550", > >> "i82551", > >> + "i82557a", > >> "i82557b", > >> + "i82557c", > >> + "i82558a", > >> + "i82558b", > >> + "i82559a", > >> + "i82559b", > >> + "i82559c", > >> "i82559er", > >> + "i82562", > >> "rtl8139", > >> "e1000", > >> "pcnet", > >> @@ -1448,9 +1457,18 @@ static const char * const pci_nic_models[] = { > >> > >> static const char * const pci_nic_names[] = { > >> "ne2k_pci", > >> + "i82550", > >> "i82551", > >> + "i82557a", > >> "i82557b", > >> + "i82557c", > >> + "i82558a", > >> + "i82558b", > >> + "i82559a", > >> + "i82559b", > >> + "i82559c", > >> "i82559er", > >> + "i82562", > >> "rtl8139", > >> "e1000", > >> "pcnet", > >> > > > > One wonders: would it be cleaner to have a single eepro100 device > > with specific model as qdev option? > > Technically that would be possible, too. > You could even have a single pci ethernet device and > specify vendor and device id as qdev options. > > I prefer the "official" device names which are also > used in the Intel documentation. eepro100 or e100 > are marketing names (more of them exist). > > Please note that this patch was marked as optional. > The arrays pci_nic_names and pci_nic_models are > not really needed, and as soon as the table of available > nics is automatically derived from the device information, > all variants of i825xx are supported automatically. > > Regards > Stefan Weil Gerd, any input on this patch? -- MST