From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nmpd3-0003Hu-GO for qemu-devel@nongnu.org; Wed, 03 Mar 2010 09:32:49 -0500 Received: from [199.232.76.173] (port=55544 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nmpd3-0003Hh-5s for qemu-devel@nongnu.org; Wed, 03 Mar 2010 09:32:49 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1Nmpd1-00054V-CB for qemu-devel@nongnu.org; Wed, 03 Mar 2010 09:32:49 -0500 Received: from mtagate5.uk.ibm.com ([194.196.100.165]:39121) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Nmpd0-00054F-V9 for qemu-devel@nongnu.org; Wed, 03 Mar 2010 09:32:47 -0500 Received: from d06nrmr1806.portsmouth.uk.ibm.com (d06nrmr1806.portsmouth.uk.ibm.com [9.149.39.193]) by mtagate5.uk.ibm.com (8.13.1/8.13.1) with ESMTP id o23EWi0x007731 for ; Wed, 3 Mar 2010 14:32:44 GMT Received: from d06av04.portsmouth.uk.ibm.com (d06av04.portsmouth.uk.ibm.com [9.149.37.216]) by d06nrmr1806.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o23EWiLq1237062 for ; Wed, 3 Mar 2010 14:32:44 GMT Received: from d06av04.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av04.portsmouth.uk.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id o23EWiYx005192 for ; Wed, 3 Mar 2010 14:32:44 GMT Received: from jens-laptop.localnet (dyn-9-152-222-51.boeblingen.de.ibm.com [9.152.222.51]) by d06av04.portsmouth.uk.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id o23EWhNK005189 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Wed, 3 Mar 2010 14:32:44 GMT From: Jens Osterkamp Date: Wed, 3 Mar 2010 15:32:43 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Message-Id: <201003031532.43257.jens@linux.vnet.ibm.com> Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH] qemu-kvm: avoid strlen of NULL pointer List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org If the user wants to create a chardev of type socket but forgets to give = a host=3D option, qemu_opt_get returns NULL. This NULL pointer is then fed = into strlen a few lines below without a check which results in a segfault. This fixes it. Signed-off-by: Jens Osterkamp --- qemu-sockets.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/qemu-sockets.c b/qemu-sockets.c index 23c3def..a191304 100644 --- a/qemu-sockets.c +++ b/qemu-sockets.c @@ -137,6 +137,9 @@ int inet_listen_opts(QemuOpts *opts, int port_offset) pstrcpy(port, sizeof(port), qemu_opt_get(opts, "port")); addr =3D qemu_opt_get(opts, "host"); =20 + if (!addr) + return -1; + to =3D qemu_opt_get_number(opts, "to", 0); if (qemu_opt_get_bool(opts, "ipv4", 0)) ai.ai_family =3D PF_INET; --=20 1.5.6.3 --=20 Best regards,=20 Jens Osterkamp -------------------------------------------------------------------------= ------- IBM Deutschland Research & Development GmbH Vorsitzender des Aufsichtsrats: Martin Jetter Gesch=E4ftsf=FChrung: Dirk Wittkopp Sitz der Gesellschaft: B=F6blingen Registergericht: Amtsgericht Stuttgart, HRB 243294