From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NnAGB-0004fJ-6S
	for qemu-devel@nongnu.org; Thu, 04 Mar 2010 07:34:35 -0500
Received: from [199.232.76.173] (port=56737 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NnAGA-0004f4-N8
	for qemu-devel@nongnu.org; Thu, 04 Mar 2010 07:34:34 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <mst@redhat.com>) id 1NnAG6-0006sZ-U8
	for qemu-devel@nongnu.org; Thu, 04 Mar 2010 07:34:34 -0500
Received: from mx1.redhat.com ([209.132.183.28]:29683)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <mst@redhat.com>) id 1NnAG6-0006sT-IZ
	for qemu-devel@nongnu.org; Thu, 04 Mar 2010 07:34:30 -0500
Received: from int-mx01.intmail.prod.int.phx2.redhat.com
	(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o24CYTjE010373
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Thu, 4 Mar 2010 07:34:29 -0500
Date: Thu, 4 Mar 2010 14:31:10 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCHv4 07/12] virtio: move typedef to qemu-common
Message-ID: <20100304123110.GA3051@redhat.com>
References: <cover.1267636215.git.mst@redhat.com>
	<9075331a15707f770788ed361f2228b88bb7a7c5.1267636215.git.mst@redhat.com>
	<20100304122019.GC8118@amit-x200.redhat.com>
	<20100304121958.GA3047@redhat.com>
	<20100304122911.GD8118@amit-x200.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20100304122911.GD8118@amit-x200.redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: kraxel@redhat.com, qemu-devel@nongnu.org, quintela@redhat.com

On Thu, Mar 04, 2010 at 05:59:11PM +0530, Amit Shah wrote:
> On (Thu) Mar 04 2010 [14:19:58], Michael S. Tsirkin wrote:
> > On Thu, Mar 04, 2010 at 05:50:19PM +0530, Amit Shah wrote:
> > > On (Wed) Mar 03 2010 [19:16:28], Michael S. Tsirkin wrote:
> > > > make it possible to use type without header include
> > > 
> > > Why?
> > 
> > So that vhost.h does not need to include virtio.h
> 
> But what's the benefit in doing that?

Simpler dependencies. E.g. tap calls vhost
init/cleanup but we do not want it to include virtio.h
An alternative would be to split init/cleanup
(does not need virtio), and start/stop (needs virtio).
But typedef in qemu-common is already used
for everything else.

> Either way, a better commit msg would help.

ok

> 		Amit