From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NnBN6-00028A-NN
	for qemu-devel@nongnu.org; Thu, 04 Mar 2010 08:45:48 -0500
Received: from [199.232.76.173] (port=54380 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NnBN6-00027p-9f
	for qemu-devel@nongnu.org; Thu, 04 Mar 2010 08:45:48 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <hch@lst.de>) id 1NnBN4-0007vA-V0
	for qemu-devel@nongnu.org; Thu, 04 Mar 2010 08:45:47 -0500
Received: from verein.lst.de ([213.95.11.210]:40249)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60)
	(envelope-from <hch@lst.de>) id 1NnBN4-0007v0-Ht
	for qemu-devel@nongnu.org; Thu, 04 Mar 2010 08:45:46 -0500
Received: from verein.lst.de (localhost [127.0.0.1])
	by verein.lst.de (8.12.3/8.12.3/Debian-7.1) with ESMTP id
	o24DjiWY003125
	(version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO)
	for <qemu-devel@nongnu.org>; Thu, 4 Mar 2010 14:45:44 +0100
Received: (from hch@localhost)
	by verein.lst.de (8.12.3/8.12.3/Debian-7.2) id o24Djixi003124
	for qemu-devel@nongnu.org; Thu, 4 Mar 2010 14:45:44 +0100
Date: Thu, 4 Mar 2010 14:45:44 +0100
From: Christoph Hellwig <hch@lst.de>
Message-ID: <20100304134544.GA3109@lst.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Subject: [Qemu-devel] [PATCH] scsi: update comment on the standards revision
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Signed-off-by: Christoph Hellwig <hch@lst.de>

Index: qemu/hw/scsi-disk.c
===================================================================
--- qemu.orig/hw/scsi-disk.c	2010-03-04 14:39:43.699022260 +0100
+++ qemu/hw/scsi-disk.c	2010-03-04 14:41:26.768255602 +0100
@@ -462,8 +462,12 @@ static int scsi_disk_emulate_inquiry(SCS
     }
     memcpy(&outbuf[8], "QEMU    ", 8);
     memcpy(&outbuf[32], s->version ? s->version : QEMU_VERSION, 4);
-    /* Identify device as SCSI-3 rev 1.
-       Some later commands are also implemented. */
+    /*
+     * We claim conformance to SPC-3, which is required for guests
+     * to ask for modern features like READ CAPACITY(16) or the
+     * block characteristics VPD page by default.  Not all of SPC-3
+     * is actually implemented, but we're good enough.
+     */
     outbuf[2] = 5;
     outbuf[3] = 2; /* Format 2 */