* [Qemu-devel] [PATCH] scsi: update comment on the standards revision
@ 2010-03-04 13:45 Christoph Hellwig
2010-03-06 22:06 ` Aurelien Jarno
0 siblings, 1 reply; 2+ messages in thread
From: Christoph Hellwig @ 2010-03-04 13:45 UTC (permalink / raw)
To: qemu-devel
Signed-off-by: Christoph Hellwig <hch@lst.de>
Index: qemu/hw/scsi-disk.c
===================================================================
--- qemu.orig/hw/scsi-disk.c 2010-03-04 14:39:43.699022260 +0100
+++ qemu/hw/scsi-disk.c 2010-03-04 14:41:26.768255602 +0100
@@ -462,8 +462,12 @@ static int scsi_disk_emulate_inquiry(SCS
}
memcpy(&outbuf[8], "QEMU ", 8);
memcpy(&outbuf[32], s->version ? s->version : QEMU_VERSION, 4);
- /* Identify device as SCSI-3 rev 1.
- Some later commands are also implemented. */
+ /*
+ * We claim conformance to SPC-3, which is required for guests
+ * to ask for modern features like READ CAPACITY(16) or the
+ * block characteristics VPD page by default. Not all of SPC-3
+ * is actually implemented, but we're good enough.
+ */
outbuf[2] = 5;
outbuf[3] = 2; /* Format 2 */
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] scsi: update comment on the standards revision
2010-03-04 13:45 [Qemu-devel] [PATCH] scsi: update comment on the standards revision Christoph Hellwig
@ 2010-03-06 22:06 ` Aurelien Jarno
0 siblings, 0 replies; 2+ messages in thread
From: Aurelien Jarno @ 2010-03-06 22:06 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: qemu-devel
On Thu, Mar 04, 2010 at 02:45:44PM +0100, Christoph Hellwig wrote:
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Thanks, applied.
> Index: qemu/hw/scsi-disk.c
> ===================================================================
> --- qemu.orig/hw/scsi-disk.c 2010-03-04 14:39:43.699022260 +0100
> +++ qemu/hw/scsi-disk.c 2010-03-04 14:41:26.768255602 +0100
> @@ -462,8 +462,12 @@ static int scsi_disk_emulate_inquiry(SCS
> }
> memcpy(&outbuf[8], "QEMU ", 8);
> memcpy(&outbuf[32], s->version ? s->version : QEMU_VERSION, 4);
> - /* Identify device as SCSI-3 rev 1.
> - Some later commands are also implemented. */
> + /*
> + * We claim conformance to SPC-3, which is required for guests
> + * to ask for modern features like READ CAPACITY(16) or the
> + * block characteristics VPD page by default. Not all of SPC-3
> + * is actually implemented, but we're good enough.
> + */
> outbuf[2] = 5;
> outbuf[3] = 2; /* Format 2 */
>
>
>
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-03-06 22:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-04 13:45 [Qemu-devel] [PATCH] scsi: update comment on the standards revision Christoph Hellwig
2010-03-06 22:06 ` Aurelien Jarno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).