From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nn6x1-00049P-Pr for qemu-devel@nongnu.org; Thu, 04 Mar 2010 04:02:36 -0500 Received: from [199.232.76.173] (port=45425 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nn6x0-00049C-1J for qemu-devel@nongnu.org; Thu, 04 Mar 2010 04:02:34 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1Nn6wy-0004sR-VC for qemu-devel@nongnu.org; Thu, 04 Mar 2010 04:02:33 -0500 Received: from e35.co.us.ibm.com ([32.97.110.153]:35965) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Nn6wy-0004s9-K4 for qemu-devel@nongnu.org; Thu, 04 Mar 2010 04:02:32 -0500 Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227]) by e35.co.us.ibm.com (8.14.3/8.13.1) with ESMTP id o248wVpa012231 for ; Thu, 4 Mar 2010 01:58:31 -0700 Received: from d03av05.boulder.ibm.com (d03av05.boulder.ibm.com [9.17.195.85]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id o2492SP8149194 for ; Thu, 4 Mar 2010 02:02:30 -0700 Received: from d03av05.boulder.ibm.com (loopback [127.0.0.1]) by d03av05.boulder.ibm.com (8.14.3/8.13.1/NCO v10.0 AVout) with ESMTP id o2492SMq019254 for ; Thu, 4 Mar 2010 02:02:28 -0700 Received: from explorer.in.ibm.com ([9.122.21.92]) by d03av05.boulder.ibm.com (8.14.3/8.13.1/NCO v10.0 AVin) with ESMTP id o2492QKr019200 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Thu, 4 Mar 2010 02:02:28 -0700 From: "M. Mohan Kumar" Date: Thu, 4 Mar 2010 14:32:24 +0530 MIME-Version: 1.0 Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Message-Id: <201003041432.24973.mohan@in.ibm.com> Subject: [Qemu-devel] [PATCH] Check for invalid initrd file List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org =46rom c5dca54f67ec6aac16c6c5e09958417b2b3ee5a1 Mon Sep 17 00:00:00 2001 =46rom: M. Mohan Kumar Date: Thu, 4 Mar 2010 14:23:07 +0530 Subject: [PATCH] Check for invalid initrd file When qemu is invoked with an invalid initrd file, it crashes. Following patch prints a error message and exits if an invalid initrd is specified. Signed-off-by: M. Mohan Kumar =2D-- hw/pc.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/hw/pc.c b/hw/pc.c index 4f6a522..551c901 100644 =2D-- a/hw/pc.c +++ b/hw/pc.c @@ -669,6 +669,12 @@ static void load_linux(void *fw_cfg, } =20 initrd_size =3D get_image_size(initrd_filename); + if (initrd_size < 0) { + fprintf(stderr, "qemu: initrd %s does not exist\n", + initrd_filename); + exit(1); + } + initrd_addr =3D (initrd_max-initrd_size) & ~4095; =20 initrd_data =3D qemu_malloc(initrd_size); =2D-=20 1.6.6.1 =2D-=20 M. Mohan Kumar, Linux Technology Center, IBM India