From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NnI08-0004w6-T9 for qemu-devel@nongnu.org; Thu, 04 Mar 2010 15:50:32 -0500 Received: from [199.232.76.173] (port=34915 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NnI08-0004vy-4b for qemu-devel@nongnu.org; Thu, 04 Mar 2010 15:50:32 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NnI06-00060K-JM for qemu-devel@nongnu.org; Thu, 04 Mar 2010 15:50:32 -0500 Received: from mx1.redhat.com ([209.132.183.28]:60337) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NnI06-000600-5T for qemu-devel@nongnu.org; Thu, 04 Mar 2010 15:50:30 -0500 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o24KoRIV025257 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 4 Mar 2010 15:50:27 -0500 Date: Thu, 4 Mar 2010 17:50:20 -0300 From: Luiz Capitulino Message-ID: <20100304175020.67e8de5a@redhat.com> In-Reply-To: <1267718231-13303-29-git-send-email-armbru@redhat.com> References: <1267718231-13303-1-git-send-email-armbru@redhat.com> <1267718231-13303-29-git-send-email-armbru@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 28/50] error: Let converted handlers print in human monitor List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org On Thu, 4 Mar 2010 16:56:49 +0100 Markus Armbruster wrote: > While fully converted handlers are not supposed to print anything when > running in a QMP monitor, they are free to print in a human monitor. I disagree. One of the key decisions behind the new Monitor design is that handlers are part of common code. User printing is output-specific and should not be done by handlers. One of the problems with this layer violation is that the consumer of this data might not be what you have assumed. For example, it has been suggested that we could move the qemu shell out of qemu in the future. In this case, this kind of information _could_ be useful. Another important problem is that free printing like this is error-prone as it's not at all clear what could be printed and there's no way to catch mistakes mechanically. Not to mention that this is for sure going to used by those who want to ignore QMP completely. I'm ok with shallow conversion, provided that handler_audit() is there to warn us about the job to be done.