qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] Fix segfault with ram_size > 4095M without kvm
@ 2010-02-23 15:13 Ryan Harper
  2010-02-23 17:02 ` Aurelien Jarno
  0 siblings, 1 reply; 10+ messages in thread
From: Ryan Harper @ 2010-02-23 15:13 UTC (permalink / raw)
  To: qemu-devel; +Cc: kvm

Currently, x86_64-softmmu qemu segfaults when trying to use > 4095M memsize.
This patch adds a simple check and error message (much like the 2047 limit on
32-bit hosts) on ram_size in the control path after we determine we're
not using kvm

Upstream qemu-kvm is affected if using the -no-kvm option; this patch address
the segfault there as well.

Signed-off-by: Ryan Harper <ryanh@us.ibm.com>
---
 vl.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/vl.c b/vl.c
index db7a178..a659e98 100644
--- a/vl.c
+++ b/vl.c
@@ -5760,6 +5760,12 @@ int main(int argc, char **argv, char **envp)
             fprintf(stderr, "failed to initialize KVM\n");
             exit(1);
         }
+    } else {
+        /* without kvm enabled, we can only support 4095 MB RAM */
+        if (ram_size > (4095UL << 20)) {
+            fprintf(stderr, "qemu: without kvm support at most 4095 MB RAM can be simulated\n");
+            exit(1);
+        }
     }
 
     if (qemu_init_main_loop()) {
-- 
1.6.3.3


-- 
Ryan Harper
Software Engineer; Linux Technology Center
IBM Corp., Austin, Tx
ryanh@us.ibm.com

^ permalink raw reply related	[flat|nested] 10+ messages in thread
* [Qemu-devel] [PATCH] Fix segfault with ram_size > 4095M without kvm
@ 2010-12-08 18:01 Luiz Capitulino
  0 siblings, 0 replies; 10+ messages in thread
From: Luiz Capitulino @ 2010-12-08 18:01 UTC (permalink / raw)
  To: qemu-devel; +Cc: amit.shah, aliguori, ryanh, aurelien

Currently, x86_64-softmmu qemu segfaults when trying to use > 4095M memsize.
This patch adds a simple check and error message (much like the 2047 limit on
32-bit hosts) on ram_size in the control path after we determine we're
not using kvm

Upstream qemu-kvm is affected if using the -no-kvm option; this patch address
the segfault there as well.

Signed-off-by: Ryan Harper <ryanh@us.ibm.com>
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
---
NOTE: this patch was applied in the v0.12.x branch, but it seems it got
      lost for master

 vl.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/vl.c b/vl.c
index 2dbb6db..bb9c21c 100644
--- a/vl.c
+++ b/vl.c
@@ -5792,6 +5792,12 @@ int main(int argc, char **argv, char **envp)
             fprintf(stderr, "failed to initialize KVM\n");
             exit(1);
         }
+    } else {
+        /* without kvm enabled, we can only support 4095 MB RAM */
+        if (ram_size > (4095UL << 20)) {
+            fprintf(stderr, "qemu: without kvm support at most 4095 MB RAM can be simulated\n");
+            exit(1);
+        }
     }
 
     if (qemu_init_main_loop()) {
-- 
1.7.3.3.402.ga48aa

^ permalink raw reply related	[flat|nested] 10+ messages in thread
end of thread, other threads:[~2010-12-08 18:01 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-23 15:13 [Qemu-devel] [PATCH] Fix segfault with ram_size > 4095M without kvm Ryan Harper
2010-02-23 17:02 ` Aurelien Jarno
2010-02-23 20:30   ` Alexander Graf
2010-02-23 21:07     ` Anthony Liguori
2010-02-23 21:24       ` Aurelien Jarno
2010-02-23 22:55   ` Ryan Harper
2010-03-04 21:27   ` Aurelien Jarno
2010-03-04 21:34     ` Ryan Harper
2010-03-06 21:31       ` Aurelien Jarno
  -- strict thread matches above, loose matches on Subject: below --
2010-12-08 18:01 Luiz Capitulino

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).