qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>,
	Christoph Hellwig <hch@lst.de>,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] block: add logical_block_size property
Date: Fri, 5 Mar 2010 10:32:24 +0100	[thread overview]
Message-ID: <20100305093224.GA7148@lst.de> (raw)
In-Reply-To: <4B90CE3D.9070104@redhat.com>

On Fri, Mar 05, 2010 at 10:26:21AM +0100, Kevin Wolf wrote:
> Is there a check anywhere that the user didn't give us an odd block
> size? We could get an interesting bit mask otherwise.

Not yet.  I used to have such a check in the first incarnation of
the block topology patches, but I have no idea how to do it in a
centralized way using the qdev attributs.

Does anyone know if there's a better way to do this than just
duplicating the check in every driver?

  reply	other threads:[~2010-03-05  9:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-04 13:20 [Qemu-devel] [PATCH] block: add logical_block_size property Christoph Hellwig
2010-03-04 14:38 ` [Qemu-devel] " Christian Borntraeger
2010-03-05  9:26 ` [Qemu-devel] " Kevin Wolf
2010-03-05  9:32   ` Christoph Hellwig [this message]
2010-03-05  9:55     ` Kevin Wolf
2010-03-16  9:23 ` Christoph Hellwig
2010-03-17  9:59 ` [Qemu-devel] " Christian Borntraeger
2010-03-17 15:59 ` [Qemu-devel] " Anthony Liguori
2010-05-03 17:29 ` Artyom Tarasenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100305093224.GA7148@lst.de \
    --to=hch@lst.de \
    --cc=borntraeger@de.ibm.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).