From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NnTtW-000377-24 for qemu-devel@nongnu.org; Fri, 05 Mar 2010 04:32:30 -0500 Received: from [199.232.76.173] (port=57510 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NnTtV-00036z-OE for qemu-devel@nongnu.org; Fri, 05 Mar 2010 04:32:29 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NnTtU-0000xn-HE for qemu-devel@nongnu.org; Fri, 05 Mar 2010 04:32:29 -0500 Received: from verein.lst.de ([213.95.11.210]:53159) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1NnTtU-0000xJ-4g for qemu-devel@nongnu.org; Fri, 05 Mar 2010 04:32:28 -0500 Date: Fri, 5 Mar 2010 10:32:24 +0100 From: Christoph Hellwig Subject: Re: [Qemu-devel] [PATCH] block: add logical_block_size property Message-ID: <20100305093224.GA7148@lst.de> References: <20100304132017.GA2200@lst.de> <4B90CE3D.9070104@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4B90CE3D.9070104@redhat.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Christian Borntraeger , Christoph Hellwig , qemu-devel@nongnu.org On Fri, Mar 05, 2010 at 10:26:21AM +0100, Kevin Wolf wrote: > Is there a check anywhere that the user didn't give us an odd block > size? We could get an interesting bit mask otherwise. Not yet. I used to have such a check in the first incarnation of the block topology patches, but I have no idea how to do it in a centralized way using the qdev attributs. Does anyone know if there's a better way to do this than just duplicating the check in every driver?