From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Andrzej Zaborowski <andrew.zaborowski@intel.com>,
Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH 3/3] tcg: declare internal helpers as const and pure
Date: Fri, 5 Mar 2010 11:15:45 +0000 [thread overview]
Message-ID: <201003051115.45657.paul@codesourcery.com> (raw)
In-Reply-To: <1267739110-26400-4-git-send-email-aurelien@aurel32.net>
> TCG internal helpers only access to the values passed in arguments, and
> do not modify the CPU internal state. Thus they can be declared as
> const and pure.
I think this needs an explanatory comment. It's not immediately obvious that
tcg_gen_helperN and tcg_gen_helper{32,64} have significantly different
semantics.
tcg/README also needs updating, specifically:
"* Helpers:
Using the tcg_gen_helper_x_y it is possible to call any function
taking i32, i64 or pointer types. Before calling an helper, all
globals are stored at their canonical location and it is assumed that
the function can modify them. In the future, function modifiers will
be allowed to tell that the helper does not read or write some globals.
"
Paul
next prev parent reply other threads:[~2010-03-05 11:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-04 21:45 [Qemu-devel] [PATCH 0/3] tcg/arm: fix division Aurelien Jarno
2010-03-04 21:45 ` [Qemu-devel] [PATCH 1/3] tcg: add div/rem 32-bit helpers Aurelien Jarno
2010-03-04 21:45 ` [Qemu-devel] [PATCH 2/3] tcg/arm: use helpers for divu/remu Aurelien Jarno
2010-03-04 21:45 ` [Qemu-devel] [PATCH 3/3] tcg: declare internal helpers as const and pure Aurelien Jarno
2010-03-05 11:15 ` Paul Brook [this message]
2010-03-05 20:07 ` Aurelien Jarno
2010-03-07 22:39 ` Paul Brook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201003051115.45657.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=andrew.zaborowski@intel.com \
--cc=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).