From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NnZgJ-0006nw-VI
	for qemu-devel@nongnu.org; Fri, 05 Mar 2010 10:43:16 -0500
Received: from [199.232.76.173] (port=54862 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NnZgJ-0006nQ-5C
	for qemu-devel@nongnu.org; Fri, 05 Mar 2010 10:43:15 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <lcapitulino@redhat.com>) id 1NnZgH-0001dy-V7
	for qemu-devel@nongnu.org; Fri, 05 Mar 2010 10:43:14 -0500
Received: from mx1.redhat.com ([209.132.183.28]:11526)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <lcapitulino@redhat.com>) id 1NnZgH-0001dm-IO
	for qemu-devel@nongnu.org; Fri, 05 Mar 2010 10:43:13 -0500
Received: from int-mx08.intmail.prod.int.phx2.redhat.com
	(int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o25FhCTf023047
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 5 Mar 2010 10:43:12 -0500
Date: Fri, 5 Mar 2010 12:43:00 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20100305124300.6d633ec9@redhat.com>
In-Reply-To: <20100304175020.67e8de5a@redhat.com>
References: <1267718231-13303-1-git-send-email-armbru@redhat.com>
	<1267718231-13303-29-git-send-email-armbru@redhat.com>
	<20100304175020.67e8de5a@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 28/50] error: Let converted handlers print
 in human monitor
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org

On Thu, 4 Mar 2010 17:50:20 -0300
Luiz Capitulino <lcapitulino@redhat.com> wrote:

> On Thu,  4 Mar 2010 16:56:49 +0100
> Markus Armbruster <armbru@redhat.com> wrote:
> 
> > While fully converted handlers are not supposed to print anything when
> > running in a QMP monitor, they are free to print in a human monitor.
> 
>  I disagree.

 I've talked to Markus by irc about this one and he convinced me that
this is the best solution for the immediate term.

 Actually, I found out that only error is printed in the human monitor
(through qerror_report()) so this is not as serious as I thought at first.

 So, I won't nack it and the bigger mid-term discussion we should have
is whether or not it's ok to mix qerror_report(), error_printf() &
friends in handlers.