From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NnZCg-0004SL-Gf for qemu-devel@nongnu.org; Fri, 05 Mar 2010 10:12:38 -0500 Received: from [199.232.76.173] (port=50549 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NnZCg-0004SD-4K for qemu-devel@nongnu.org; Fri, 05 Mar 2010 10:12:38 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NnZCd-0006Ir-Km for qemu-devel@nongnu.org; Fri, 05 Mar 2010 10:12:37 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42388) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NnZCd-0006Ij-7o for qemu-devel@nongnu.org; Fri, 05 Mar 2010 10:12:35 -0500 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o25FCWDX025014 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 5 Mar 2010 10:12:33 -0500 Date: Fri, 5 Mar 2010 17:12:27 +0200 From: Shahar Havivi Message-ID: <20100305151222.GA21283@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Subject: [Qemu-devel] [PATCH] Wrong error message in block_passwd command List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Luiz Capitulino , Dor Laor Monitor command 'block_passwd' reports a wrong error message when drive is not encrypted Signed-off-by: Shahar Havivi --- block.c | 9 ++++++--- monitor.c | 7 ++++++- qerror.c | 4 ++++ qerror.h | 3 +++ 4 files changed, 19 insertions(+), 4 deletions(-) diff --git a/block.c b/block.c index 31d1ba4..dd484fa 100644 --- a/block.c +++ b/block.c @@ -1132,10 +1132,13 @@ int bdrv_set_key(BlockDriverState *bs, const char *key) if (ret < 0) return ret; if (!bs->encrypted) - return 0; + return -EINVAL; + } + if (!bs->encrypted) { + return -EINVAL; + } else if (!bs->drv || !bs->drv->bdrv_set_key) { + return -ENOMEDIUM; } - if (!bs->encrypted || !bs->drv || !bs->drv->bdrv_set_key) - return -1; ret = bs->drv->bdrv_set_key(bs, key); if (ret < 0) { bs->valid_key = 0; diff --git a/monitor.c b/monitor.c index 19470d1..30dcbbe 100644 --- a/monitor.c +++ b/monitor.c @@ -1042,6 +1042,7 @@ static int do_block_set_passwd(Monitor *mon, const QDict *qdict, QObject **ret_data) { BlockDriverState *bs; + int err; bs = bdrv_find(qdict_get_str(qdict, "device")); if (!bs) { @@ -1049,7 +1050,11 @@ static int do_block_set_passwd(Monitor *mon, const QDict *qdict, return -1; } - if (bdrv_set_key(bs, qdict_get_str(qdict, "password")) < 0) { + err = bdrv_set_key(bs, qdict_get_str(qdict, "password")); + if (err == -EINVAL) { + qemu_error_new(QERR_DEVICE_NOT_ENCRYPTED, bdrv_get_device_name(bs)); + return -1; + } else if (err < 0) { qemu_error_new(QERR_INVALID_PASSWORD); return -1; } diff --git a/qerror.c b/qerror.c index 2f657f4..4e63a54 100644 --- a/qerror.c +++ b/qerror.c @@ -49,6 +49,10 @@ static const QErrorStringTable qerror_table[] = { .desc = "The %(device) is encrypted", }, { + .error_fmt = QERR_DEVICE_NOT_ENCRYPTED, + .desc = "Device '%(device)' is not encrypted", + }, + { .error_fmt = QERR_DEVICE_LOCKED, .desc = "Device %(device) is locked", }, diff --git a/qerror.h b/qerror.h index ee59615..b93fff6 100644 --- a/qerror.h +++ b/qerror.h @@ -46,6 +46,9 @@ QError *qobject_to_qerror(const QObject *obj); #define QERR_DEVICE_ENCRYPTED \ "{ 'class': 'DeviceEncrypted', 'data': { 'device': %s } }" +#define QERR_DEVICE_NOT_ENCRYPTED \ + "{ 'class': 'DeviceNotEncrypted', 'data': { 'device': %s } }" + #define QERR_DEVICE_LOCKED \ "{ 'class': 'DeviceLocked', 'data': { 'device': %s } }" -- 1.6.3.3