qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Aurelien Jarno <aurelien@aurel32.net>
To: Hui Zhu <teawater@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] qustion about x86 sse insn "lddqu"
Date: Sat, 6 Mar 2010 19:17:33 +0100	[thread overview]
Message-ID: <20100306181733.GA14275@volta.aurel32.net> (raw)
In-Reply-To: <daef60380912022129r10b9fe9t65219c081ae92bd7@mail.gmail.com>

On Thu, Dec 03, 2009 at 01:29:23PM +0800, Hui Zhu wrote:
> Hi,
> 
> In qemu 0.11.0, it handle lddqu as:
>         case 0x3f0: /* lddqu */
>             if (mod == 3)
>                 goto illegal_op;
>             gen_lea_modrm(s, modrm, &reg_addr, &offset_addr);
>             gen_sto_env_A0(s->mem_index, offsetof(CPUX86State,xmm_regs[reg]));
>             break;
> It st the value of xmm[reg] to address A0, right?
> 
> But in intel doc about this insn:
> LDDQU—Load Unaligned Integer 128 Bits
> The instruction is functionally similar to MOVDQU xmm, m128 for loading from
> memory. That is: 16 bytes of data starting at an address specified by the source
> memory operand (second operand) are fetched from memory and placed in
> a destination
> register (first operand). The source operand need not be aligned on a 16-byte
> boundary. Up to 32 bytes may be loaded from memory; this is implementation
> dependent.
> 
> Did I miss something? Or this code have some bug?
> 

The patch is indeed wrong, I have just committed a patch to fix the
problem.

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net

      reply	other threads:[~2010-03-06 18:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-03  5:29 [Qemu-devel] qustion about x86 sse insn "lddqu" Hui Zhu
2010-03-06 18:17 ` Aurelien Jarno [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100306181733.GA14275@volta.aurel32.net \
    --to=aurelien@aurel32.net \
    --cc=qemu-devel@nongnu.org \
    --cc=teawater@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).