From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NnyiG-0005Ho-BL for qemu-devel@nongnu.org; Sat, 06 Mar 2010 13:26:56 -0500 Received: from [199.232.76.173] (port=39994 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NnyiG-0005Ha-0E for qemu-devel@nongnu.org; Sat, 06 Mar 2010 13:26:56 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NnyiD-0003kf-Mg for qemu-devel@nongnu.org; Sat, 06 Mar 2010 13:26:55 -0500 Received: from hall.aurel32.net ([88.191.82.174]:56719) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NnyiC-0003js-Jv for qemu-devel@nongnu.org; Sat, 06 Mar 2010 13:26:52 -0500 Date: Sat, 6 Mar 2010 19:26:43 +0100 From: Aurelien Jarno Subject: Re: [Qemu-devel] [PATCH 05/13] cpuid: add missing CPUID feature flag names Message-ID: <20100306182643.GF14275@volta.aurel32.net> References: <1265105301-3455-1-git-send-email-andre.przywara@amd.com> <1265105301-3455-6-git-send-email-andre.przywara@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <1265105301-3455-6-git-send-email-andre.przywara@amd.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andre Przywara Cc: john.cooper@redhat.com, qemu-devel@nongnu.org On Tue, Feb 02, 2010 at 11:08:13AM +0100, Andre Przywara wrote: > Some CPUID feature flags had no string value, so they could not be > switched on or off from the command line. > Add names for the missing ones mentioned in the current public CPUID > specification from both Intel and AMD. Those only mentioned in the > Linux kernel source I put as comments. > > Signed-off-by: Andre Przywara Acked-by: Aurelien Jarno > --- > target-i386/cpuid.c | 15 ++++++++------- > 1 files changed, 8 insertions(+), 7 deletions(-) > > diff --git a/target-i386/cpuid.c b/target-i386/cpuid.c > index 0238718..19d58e1 100644 > --- a/target-i386/cpuid.c > +++ b/target-i386/cpuid.c > @@ -52,11 +52,11 @@ static const char *feature_name[] = { > "fxsr", "sse", "sse2", "ss", "ht" /* Intel htt */, "tm", "ia64", "pbe", > }; > static const char *ext_feature_name[] = { > - "pni" /* Intel,AMD sse3 */, NULL, NULL, "monitor", > - "ds_cpl", "vmx", NULL /* Linux smx */, "est", > - "tm2", "ssse3", "cid", NULL, NULL, "cx16", "xtpr", NULL, > - NULL, NULL, "dca", NULL, NULL, NULL, NULL, "popcnt", > - NULL, NULL, NULL, NULL, NULL, NULL, NULL, "hypervisor", > + "pni" /* Intel,AMD sse3 */, "pclmuldq", "dtes64", "monitor", > + "ds_cpl", "vmx", "smx", "est", > + "tm2", "ssse3", "cid", NULL, NULL /* FMA */, "cx16", "xtpr", "pdcm", > + NULL, NULL, "dca", "sse4_1", "sse4_2", "x2apic", "movbe", "popcnt", > + NULL, "aes", "xsave", "osxsave", NULL /* AVX */, NULL, NULL, "hypervisor", > }; > static const char *ext2_feature_name[] = { > "fpu", "vme", "de", "pse", "tsc", "msr", "pae", "mce", > @@ -71,8 +71,9 @@ static const char *ext3_feature_name[] = { > "lahf_lm" /* AMD LahfSahf */, "cmp_legacy", > "svm", "extapic" /* AMD ExtApicSpace */, > "cr8legacy" /* AMD AltMovCr8 */, "abm", "sse4a", "misalignsse", > - "3dnowprefetch", "osvw", NULL /* Linux ibs */, NULL, "skinit", "wdt", NULL, NULL, > - NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, > + "3dnowprefetch", "osvw", "ibs", NULL /* SSE-5 */, > + "skinit", "wdt", NULL, NULL, > + NULL, NULL, NULL, "nodeid_msr", NULL, NULL, NULL, NULL, > NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, > }; > > -- > 1.6.4 > > > > > -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net