From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1No28h-0005Hw-Mo
	for qemu-devel@nongnu.org; Sat, 06 Mar 2010 17:06:27 -0500
Received: from [199.232.76.173] (port=33974 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1No28g-0005HQ-Uz
	for qemu-devel@nongnu.org; Sat, 06 Mar 2010 17:06:26 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <aurelien@aurel32.net>) id 1No28f-0001aT-J5
	for qemu-devel@nongnu.org; Sat, 06 Mar 2010 17:06:26 -0500
Received: from hall.aurel32.net ([88.191.82.174]:48871)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <aurelien@aurel32.net>)
	id 1No28f-0001aL-2l
	for qemu-devel@nongnu.org; Sat, 06 Mar 2010 17:06:25 -0500
Date: Sat, 6 Mar 2010 23:06:15 +0100
From: Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH] scsi: update comment on the standards
	revision
Message-ID: <20100306220615.GP14275@volta.aurel32.net>
References: <20100304134544.GA3109@lst.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <20100304134544.GA3109@lst.de>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Christoph Hellwig <hch@lst.de>
Cc: qemu-devel@nongnu.org

On Thu, Mar 04, 2010 at 02:45:44PM +0100, Christoph Hellwig wrote:
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Thanks, applied.

> Index: qemu/hw/scsi-disk.c
> ===================================================================
> --- qemu.orig/hw/scsi-disk.c	2010-03-04 14:39:43.699022260 +0100
> +++ qemu/hw/scsi-disk.c	2010-03-04 14:41:26.768255602 +0100
> @@ -462,8 +462,12 @@ static int scsi_disk_emulate_inquiry(SCS
>      }
>      memcpy(&outbuf[8], "QEMU    ", 8);
>      memcpy(&outbuf[32], s->version ? s->version : QEMU_VERSION, 4);
> -    /* Identify device as SCSI-3 rev 1.
> -       Some later commands are also implemented. */
> +    /*
> +     * We claim conformance to SPC-3, which is required for guests
> +     * to ask for modern features like READ CAPACITY(16) or the
> +     * block characteristics VPD page by default.  Not all of SPC-3
> +     * is actually implemented, but we're good enough.
> +     */
>      outbuf[2] = 5;
>      outbuf[3] = 2; /* Format 2 */
>  
> 
> 
> 

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net