From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Andrzej Zaborowski <andrew.zaborowski@intel.com>,
Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH 3/3] tcg: declare internal helpers as const and pure
Date: Sun, 7 Mar 2010 22:39:12 +0000 [thread overview]
Message-ID: <201003072239.13056.paul@codesourcery.com> (raw)
In-Reply-To: <20100305200731.GW10291@volta.aurel32.net>
> On Fri, Mar 05, 2010 at 11:15:45AM +0000, Paul Brook wrote:
> > > TCG internal helpers only access to the values passed in arguments, and
> > > do not modify the CPU internal state. Thus they can be declared as
> > > const and pure.
> >
> > I think this needs an explanatory comment. It's not immediately obvious
> > that tcg_gen_helperN and tcg_gen_helper{32,64} have significantly
> > different semantics.
>
> What do you mean exactly? Mentioning explicitly tcg_gen_helper{32,64}
> instead of "TCG internal helpers".
I think the difference between tcg_gen_helperN and tcg_gen_helper{32,64} is
sufficiently subtle that it deserves documenting. It's not obvious that the
latter may only be used for cont/pure helpers. My guess is that the FIXME
you're removing was added precisely because there was uncertainty whether this
assumption was reasonable, and under which circumstances they are used.
Paul
prev parent reply other threads:[~2010-03-07 23:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-04 21:45 [Qemu-devel] [PATCH 0/3] tcg/arm: fix division Aurelien Jarno
2010-03-04 21:45 ` [Qemu-devel] [PATCH 1/3] tcg: add div/rem 32-bit helpers Aurelien Jarno
2010-03-04 21:45 ` [Qemu-devel] [PATCH 2/3] tcg/arm: use helpers for divu/remu Aurelien Jarno
2010-03-04 21:45 ` [Qemu-devel] [PATCH 3/3] tcg: declare internal helpers as const and pure Aurelien Jarno
2010-03-05 11:15 ` Paul Brook
2010-03-05 20:07 ` Aurelien Jarno
2010-03-07 22:39 ` Paul Brook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201003072239.13056.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=andrew.zaborowski@intel.com \
--cc=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).