qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Luiz Capitulino <lcapitulino@redhat.com>
To: Shahar Havivi <shaharh@redhat.com>
Cc: Dor Laor <dlaor@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/2] Fix block_passwd monitor command error
Date: Mon, 8 Mar 2010 17:48:41 -0300	[thread overview]
Message-ID: <20100308174841.7475605f@redhat.com> (raw)
In-Reply-To: <cover.1267827125.git.shaharh@redhat.com>

On Sat, 6 Mar 2010 00:24:53 +0200
Shahar Havivi <shaharh@redhat.com> wrote:

> The next two patches fix the wrong error message in block_passwd
> monitor command: when trying to decrypt un-encrypted drive, user
> get error wrong password.
> 
> "1" add error message to qerror.h and qerror.c
> "2" patch the monitor command error handling

 Looks good to me.

> 
> Shahar Havivi (2):
>   QError: New QERR_DEVICE_NOT_ENCRYPTED
>   Wrong error message in block_passwd command
> 
>  block.c   |    7 +++++--
>  monitor.c |    7 ++++++-
>  qerror.c  |    4 ++++
>  qerror.h  |    3 +++
>  4 files changed, 18 insertions(+), 3 deletions(-)
> 
> 
> 

      parent reply	other threads:[~2010-03-08 20:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-05 22:24 [Qemu-devel] [PATCH 0/2] Fix block_passwd monitor command error Shahar Havivi
2010-03-05 22:25 ` [Qemu-devel] [PATCH 1/2] QError: New QERR_DEVICE_NOT_ENCRYPTED Shahar Havivi
2010-03-17 16:20   ` Anthony Liguori
2010-03-05 22:26 ` [Qemu-devel] [PATCH 2/2] Wrong error message in block_passwd command Shahar Havivi
2010-03-08  8:46 ` [Qemu-devel] [PATCH 0/2] Fix block_passwd monitor command error Kevin Wolf
2010-03-08 20:48 ` Luiz Capitulino [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100308174841.7475605f@redhat.com \
    --to=lcapitulino@redhat.com \
    --cc=dlaor@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=shaharh@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).