From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Nojsi-0007KZ-Af
	for qemu-devel@nongnu.org; Mon, 08 Mar 2010 15:48:52 -0500
Received: from [199.232.76.173] (port=44048 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Nojsi-0007KL-19
	for qemu-devel@nongnu.org; Mon, 08 Mar 2010 15:48:52 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <lcapitulino@redhat.com>) id 1Nojsg-0007oX-3M
	for qemu-devel@nongnu.org; Mon, 08 Mar 2010 15:48:51 -0500
Received: from mx1.redhat.com ([209.132.183.28]:30842)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <lcapitulino@redhat.com>) id 1Nojsf-0007oP-NW
	for qemu-devel@nongnu.org; Mon, 08 Mar 2010 15:48:49 -0500
Received: from int-mx04.intmail.prod.int.phx2.redhat.com
	(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o28Kml91029062
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Mon, 8 Mar 2010 15:48:48 -0500
Date: Mon, 8 Mar 2010 17:48:41 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/2] Fix block_passwd monitor command error
Message-ID: <20100308174841.7475605f@redhat.com>
In-Reply-To: <cover.1267827125.git.shaharh@redhat.com>
References: <cover.1267827125.git.shaharh@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Shahar Havivi <shaharh@redhat.com>
Cc: Dor Laor <dlaor@redhat.com>, qemu-devel@nongnu.org

On Sat, 6 Mar 2010 00:24:53 +0200
Shahar Havivi <shaharh@redhat.com> wrote:

> The next two patches fix the wrong error message in block_passwd
> monitor command: when trying to decrypt un-encrypted drive, user
> get error wrong password.
> 
> "1" add error message to qerror.h and qerror.c
> "2" patch the monitor command error handling

 Looks good to me.

> 
> Shahar Havivi (2):
>   QError: New QERR_DEVICE_NOT_ENCRYPTED
>   Wrong error message in block_passwd command
> 
>  block.c   |    7 +++++--
>  monitor.c |    7 ++++++-
>  qerror.c  |    4 ++++
>  qerror.h  |    3 +++
>  4 files changed, 18 insertions(+), 3 deletions(-)
> 
> 
>