From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NohTz-0000YM-84
	for qemu-devel@nongnu.org; Mon, 08 Mar 2010 13:15:11 -0500
Received: from [199.232.76.173] (port=36394 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NohTy-0000Y6-Nm
	for qemu-devel@nongnu.org; Mon, 08 Mar 2010 13:15:10 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <mst@redhat.com>) id 1NohTx-0001TD-Ap
	for qemu-devel@nongnu.org; Mon, 08 Mar 2010 13:15:10 -0500
Received: from mx1.redhat.com ([209.132.183.28]:6453)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <mst@redhat.com>) id 1NohTw-0001SH-K4
	for qemu-devel@nongnu.org; Mon, 08 Mar 2010 13:15:08 -0500
Date: Mon, 8 Mar 2010 20:11:18 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20100308181118.GA13134@redhat.com>
References: <cover.1267636215.git.mst@redhat.com>
	<be4ce3d477c6a1133743de04f8e521d2775ace6e.1267636215.git.mst@redhat.com>
	<20100305130835.GD22141@amit-x200.redhat.com>
	<20100306190757.GC12235@redhat.com>
	<20100308061646.GC8436@amit-x200.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20100308061646.GC8436@amit-x200.redhat.com>
Subject: [Qemu-devel] Re: [PATCHv4 05/12] virtio: add APIs for queue fields
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: quintela@redhat.com, qemu-devel@nongnu.org, kraxel@redhat.com

On Mon, Mar 08, 2010 at 11:46:46AM +0530, Amit Shah wrote:
> On (Sat) Mar 06 2010 [21:07:57], Michael S. Tsirkin wrote:
> > On Fri, Mar 05, 2010 at 06:38:35PM +0530, Amit Shah wrote:
> > > On (Wed) Mar 03 2010 [19:16:09], Michael S. Tsirkin wrote:
> > > > +
> > > > +EventNotifier *virtio_queue_guest_notifier(VirtQueue *vq)
> > > > +{
> > > > +    return &vq->guest_notifier;
> > > > +}
> > > > +EventNotifier *virtio_queue_host_notifier(VirtQueue *vq)
> > > > +{
> > > > +    return &vq->host_notifier;
> > > > +}
> > > 
> > > Where are these host_notifier and guest_notifier fields set? Am I
> > > completely missing it?
> > 
> > What do you mean by "set"?
> > You get a pointer, you can e.g. init it.
> 
> I mean where is vq->host_notifier initialised?
> 
> 		Amit

There's a function to do this. Called from virtio-pci.