From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Np0Wt-0006qF-92 for qemu-devel@nongnu.org; Tue, 09 Mar 2010 09:35:27 -0500 Received: from [199.232.76.173] (port=44128 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Np0Wq-0006oB-J0 for qemu-devel@nongnu.org; Tue, 09 Mar 2010 09:35:24 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1Np0Kw-0006dK-H9 for qemu-devel@nongnu.org; Tue, 09 Mar 2010 09:23:07 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48172) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Np0Kw-0006cy-5Q for qemu-devel@nongnu.org; Tue, 09 Mar 2010 09:23:06 -0500 Date: Tue, 9 Mar 2010 11:22:56 -0300 From: Luiz Capitulino Message-ID: <20100309112256.56e43d16@redhat.com> In-Reply-To: References: <1264537055.2890.40.camel@aglitke> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: virtio: Add memory statistics reporting to the balloon driver (V8) List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: Anthony Liguori , Avi Kivity , qemu-devel@nongnu.org, Adam Litke On Tue, 09 Mar 2010 14:51:31 +0100 Juan Quintela wrote: > Any recompilation/etc would break migration. I have tried to understand > what happened with monitor async commands, and my head exploded in > indirections. The Monitor needs lots of cleanups to make things more obvious. > Is there any written explanation of what are we trying to do here? Only the commit log 940cc30. Basically, an asynchronous handler has a completion function which is called when the handler completes. If we're in the user Monitor, it's suspended until the completion function is called. In QMP, the handler returns immediately and we _should_ be emitting an event when we have the answer. The current code doesn't do that, which seems to be a new issue.