From: Luiz Capitulino <lcapitulino@redhat.com>
To: Adam Litke <agl@us.ibm.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
Avi Kivity <avi@redhat.com>,
qemu-devel@nongnu.org, Juan Quintela <quintela@redhat.com>
Subject: [Qemu-devel] Re: virtio: Add memory statistics reporting to the balloon driver (V8)
Date: Tue, 9 Mar 2010 11:56:35 -0300 [thread overview]
Message-ID: <20100309115635.07228763@redhat.com> (raw)
In-Reply-To: <1268146123.2579.53.camel@aglitke>
On Tue, 09 Mar 2010 08:48:43 -0600
Adam Litke <agl@us.ibm.com> wrote:
> On Tue, 2010-03-09 at 11:22 -0300, Luiz Capitulino wrote:
> > On Tue, 09 Mar 2010 14:51:31 +0100
> > Juan Quintela <quintela@redhat.com> wrote:
> >
> > > Any recompilation/etc would break migration. I have tried to understand
> > > what happened with monitor async commands, and my head exploded in
> > > indirections.
> >
> > The Monitor needs lots of cleanups to make things more obvious.
> >
> > > Is there any written explanation of what are we trying to do here?
> >
> > Only the commit log 940cc30.
> >
> > Basically, an asynchronous handler has a completion function which is
> > called when the handler completes.
> >
> > If we're in the user Monitor, it's suspended until the completion
> > function is called. In QMP, the handler returns immediately and we
> > _should_ be emitting an event when we have the answer.
> >
> > The current code doesn't do that, which seems to be a new issue.
>
> With current git, I cannot get QMP to recognize any commands. Unless
> this is a known issue, I will look into it further to see what has
> caused it.
You have to issue the 'qmp_capabilites' command before issuing commands,
take a look at the QMP/README and QMP/qmp-spec.txt files.
prev parent reply other threads:[~2010-03-09 14:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-26 20:17 [Qemu-devel] virtio: Add memory statistics reporting to the balloon driver (V8) Adam Litke
2010-01-27 0:08 ` Anthony Liguori
2010-03-09 13:51 ` [Qemu-devel] " Juan Quintela
2010-03-09 14:22 ` Luiz Capitulino
2010-03-09 14:48 ` Adam Litke
2010-03-09 14:56 ` Luiz Capitulino [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100309115635.07228763@redhat.com \
--to=lcapitulino@redhat.com \
--cc=agl@us.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).