From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NpiwL-0002zO-Kq
	for qemu-devel@nongnu.org; Thu, 11 Mar 2010 09:00:41 -0500
Received: from [199.232.76.173] (port=40341 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NpiwK-0002zE-DF
	for qemu-devel@nongnu.org; Thu, 11 Mar 2010 09:00:40 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <paul@codesourcery.com>) id 1NpiwJ-00030x-FS
	for qemu-devel@nongnu.org; Thu, 11 Mar 2010 09:00:39 -0500
Received: from mx20.gnu.org ([199.232.41.8]:37494)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <paul@codesourcery.com>)
	id 1NpiwF-0002wm-QH
	for qemu-devel@nongnu.org; Thu, 11 Mar 2010 09:00:39 -0500
Received: from mail.codesourcery.com ([38.113.113.100])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1NpiuG-0003iO-E2
	for qemu-devel@nongnu.org; Thu, 11 Mar 2010 08:58:32 -0500
From: Paul Brook <paul@codesourcery.com>
Date: Thu, 11 Mar 2010 13:58:22 +0000
References: <1268239869-16058-1-git-send-email-aliguori@us.ibm.com>
	<201003111257.59828.paul@codesourcery.com>
	<4B98EF51.7040905@redhat.com>
In-Reply-To: <4B98EF51.7040905@redhat.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Message-Id: <201003111358.23200.paul@codesourcery.com>
Subject: [Qemu-devel] Re: [PATCH 1/7] Add support for generic notifier lists
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, Luiz Capitulino <lcapitulino@redhat.com>, qemu-devel@nongnu.org, Gerd Hoffman <kraxel@redhat.com>

> On 03/11/2010 01:57 PM, Paul Brook wrote:
> > +struct QEMUNotifier
> >
> > >  +{
> > >  +    void (*notify)(QEMUNotifier *notifier);
> > >  +};
> >
> > I suggest combining this with QEMUBH.
> 
> I didn't understand this suggestion exactly, but I think it's related
> that I didn't understand the advantage of making QEMUNotifier a struct.

My point is that we already have a mechanism for providing event notification 
callbacks, specifically QEMUBH.  Why invent a new one?

Paul