From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NprUh-0007nD-1R
	for qemu-devel@nongnu.org; Thu, 11 Mar 2010 18:08:43 -0500
Received: from [199.232.76.173] (port=52714 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NprUf-0007n2-Cz
	for qemu-devel@nongnu.org; Thu, 11 Mar 2010 18:08:41 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <jamie@shareable.org>) id 1NprUc-000516-1W
	for qemu-devel@nongnu.org; Thu, 11 Mar 2010 18:08:41 -0500
Received: from mail2.shareable.org ([80.68.89.115]:39407)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <jamie@shareable.org>) id 1NprUb-00050y-NL
	for qemu-devel@nongnu.org; Thu, 11 Mar 2010 18:08:37 -0500
Date: Thu, 11 Mar 2010 23:08:34 +0000
From: Jamie Lokier <jamie@shareable.org>
Subject: Re: [Qemu-devel] Re: [PATCH] CODING_STYLE: Reserve qemu_ prefix for
	library wrappers
Message-ID: <20100311230834.GB15170@shareable.org>
References: <4B98FA68.7000901@codemonkey.ws>
	<1268318923-13397-1-git-send-email-avi@redhat.com>
	<4B990445.5030303@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4B990445.5030303@codemonkey.ws>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Avi Kivity <avi@redhat.com>, qemu-devel@nongnu.org

Anthony Liguori wrote:
> On 03/11/2010 08:48 AM, Avi Kivity wrote:
> >Signed-off-by: Avi Kivity<avi@redhat.com>
> >---
> >  CODING_STYLE |    3 +++
> >  1 files changed, 3 insertions(+), 0 deletions(-)
> >
> >diff --git a/CODING_STYLE b/CODING_STYLE
> >index a579cb1..92036f3 100644
> >--- a/CODING_STYLE
> >+++ b/CODING_STYLE
> >@@ -49,6 +49,9 @@ and is therefore likely to be changed.
> >  Typedefs are used to eliminate the redundant 'struct' keyword.  It is the
> >  QEMU coding style.
> >
> >+When wrapping standard library functions, use the prefix qemu_ to alert
> >+readers that they are seeing a wrapped version; otherwise avoid this 
> >prefix.
> >+
> >   
> 
> Acked-by: Anthony Liguori <aliguori@us.ibm.com>
> 
> But I'd like to also see others agree with this.

I agree - not that I've contributed any code, mind you, but I do read
bits of it from time to time.

However if qemu is ever made into a library used by other
applications, i.e. libqemu.a or libqemu.so, then you might decide
application-visible functions should have the prefix

-- Jamie