From: Marcelo Tosatti <mtosatti@redhat.com>
To: kvm@vger.kernel.org, qemu-devel@nongnu.org
Cc: amit.shah@redhat.com, Marcelo Tosatti <mtosatti@redhat.com>,
avi@redhat.com
Subject: [Qemu-devel] [patch 1/2] Pass QEMUIOWorker to qemu_notify_event
Date: Thu, 11 Mar 2010 23:45:50 -0300 [thread overview]
Message-ID: <20100312024808.111854028@redhat.com> (raw)
In-Reply-To: 20100312024549.787893344@redhat.com
[-- Attachment #1: qemu-io-worker --]
[-- Type: text/plain, Size: 4231 bytes --]
This can be used later to introduce generic iothread workers.
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
Index: qemu-ioworker/async.c
===================================================================
--- qemu-ioworker.orig/async.c
+++ qemu-ioworker/async.c
@@ -180,7 +180,7 @@ void qemu_bh_schedule(QEMUBH *bh)
bh->scheduled = 1;
bh->idle = 0;
/* stop the currently executing CPU to execute the BH ASAP */
- qemu_notify_event();
+ qemu_notify_event(main_io_worker);
}
void qemu_bh_cancel(QEMUBH *bh)
Index: qemu-ioworker/hw/mac_dbdma.c
===================================================================
--- qemu-ioworker.orig/hw/mac_dbdma.c
+++ qemu-ioworker/hw/mac_dbdma.c
@@ -655,7 +655,7 @@ void DBDMA_register_channel(void *dbdma,
void DBDMA_schedule(void)
{
- qemu_notify_event();
+ qemu_notify_event(main_io_worker);
}
static void
Index: qemu-ioworker/hw/virtio-net.c
===================================================================
--- qemu-ioworker.orig/hw/virtio-net.c
+++ qemu-ioworker/hw/virtio-net.c
@@ -359,7 +359,7 @@ static void virtio_net_handle_rx(VirtIOD
/* We now have RX buffers, signal to the IO thread to break out of the
* select to re-poll the tap file descriptor */
- qemu_notify_event();
+ qemu_notify_event(main_io_worker);
}
static int virtio_net_can_receive(VLANClientState *nc)
Index: qemu-ioworker/qemu-common.h
===================================================================
--- qemu-ioworker.orig/qemu-common.h
+++ qemu-ioworker/qemu-common.h
@@ -234,11 +234,17 @@ typedef uint64_t pcibus_t;
void cpu_save(QEMUFile *f, void *opaque);
int cpu_load(QEMUFile *f, void *opaque, int version_id);
+typedef struct QEMUIOWorker {
+ void *opaque;
+} QEMUIOWorker;
+
/* Force QEMU to stop what it's doing and service IO */
void qemu_service_io(void);
/* Force QEMU to process pending events */
-void qemu_notify_event(void);
+void qemu_notify_event(QEMUIOWorker *worker);
+
+extern QEMUIOWorker *main_io_worker;
/* Unblock cpu */
void qemu_cpu_kick(void *env);
Index: qemu-ioworker/vl.c
===================================================================
--- qemu-ioworker.orig/vl.c
+++ qemu-ioworker/vl.c
@@ -274,6 +274,9 @@ uint8_t qemu_uuid[16];
static QEMUBootSetHandler *boot_set_handler;
static void *boot_set_opaque;
+QEMUIOWorker iothread_worker;
+QEMUIOWorker *main_io_worker = &iothread_worker;
+
#ifdef SIGRTMIN
#define SIG_IPI (SIGRTMIN+4)
#else
@@ -885,7 +888,7 @@ void qemu_mod_timer(QEMUTimer *ts, int64
}
/* Interrupt execution to force deadline recalculation. */
if (use_icount)
- qemu_notify_event();
+ qemu_notify_event(main_io_worker);
}
}
@@ -1062,7 +1065,7 @@ static void host_alarm_handler(int host_
}
#endif
timer_alarm_pending = 1;
- qemu_notify_event();
+ qemu_notify_event(main_io_worker);
}
}
@@ -2928,7 +2931,7 @@ static int ram_load(QEMUFile *f, void *o
void qemu_service_io(void)
{
- qemu_notify_event();
+ qemu_notify_event(main_io_worker);
}
/***********************************************************/
@@ -3180,26 +3183,26 @@ void qemu_system_reset_request(void)
} else {
reset_requested = 1;
}
- qemu_notify_event();
+ qemu_notify_event(main_io_worker);
}
void qemu_system_shutdown_request(void)
{
shutdown_requested = 1;
- qemu_notify_event();
+ qemu_notify_event(main_io_worker);
}
void qemu_system_powerdown_request(void)
{
powerdown_requested = 1;
- qemu_notify_event();
+ qemu_notify_event(main_io_worker);
}
#ifdef CONFIG_IOTHREAD
static void qemu_system_vmstop_request(int reason)
{
vmstop_requested = reason;
- qemu_notify_event();
+ qemu_notify_event(main_io_worker);
}
#endif
@@ -3341,7 +3344,7 @@ void qemu_cpu_kick(void *env)
return;
}
-void qemu_notify_event(void)
+void qemu_notify_event(QEMUIOWorker *worker)
{
CPUState *env = cpu_single_env;
@@ -3727,7 +3730,7 @@ void qemu_init_vcpu(void *_env)
tcg_init_vcpu(env);
}
-void qemu_notify_event(void)
+void qemu_notify_event(QEMUIOWorker *worker)
{
qemu_event_increment();
}
next prev parent reply other threads:[~2010-03-12 2:51 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-22 13:59 [Qemu-devel] [patch uq/master 0/2] wake iothread on virtio kick / flush_coalesced_mmio smp_wmb Marcelo Tosatti
2010-02-22 13:59 ` [Qemu-devel] [patch uq/master 1/2] virtio-pci: wake up iothread on VIRTIO_PCI_QUEUE_NOTIFY Marcelo Tosatti
2010-02-22 14:20 ` [Qemu-devel] " Avi Kivity
2010-02-22 14:29 ` Marcelo Tosatti
2010-02-22 14:51 ` Avi Kivity
2010-02-22 15:16 ` Marcelo Tosatti
2010-02-22 15:29 ` Anthony Liguori
2010-02-22 15:32 ` Avi Kivity
2010-02-22 15:42 ` Anthony Liguori
2010-02-22 15:55 ` Avi Kivity
2010-03-12 2:45 ` [Qemu-devel] [patch 0/2] introduce QEMUIOWorker and wake up iothread on virtio-serial-bus notification Marcelo Tosatti
2010-03-12 2:45 ` Marcelo Tosatti [this message]
2010-03-22 21:16 ` [Qemu-devel] [patch 1/2] Pass QEMUIOWorker to qemu_notify_event Anthony Liguori
2010-03-25 13:47 ` [Qemu-devel] [patch 0/2] introduce QEMUIOWorker and wake up iothread on virtio-serial-bus notification (v2) Marcelo Tosatti
2010-03-25 13:47 ` [Qemu-devel] [patch 1/2] Pass QEMUIOWorker to qemu_notify_event Marcelo Tosatti
2010-03-25 21:06 ` Paul Brook
2010-03-26 3:55 ` Marcelo Tosatti
2010-03-26 15:23 ` Paul Brook
2010-03-26 15:40 ` Anthony Liguori
2010-03-25 13:47 ` [Qemu-devel] [patch 2/2] virtio-serial-bus: wake up iothread upon guest read notification Marcelo Tosatti
2010-03-12 2:45 ` Marcelo Tosatti
2010-03-12 5:53 ` [Qemu-devel] " Amit Shah
2010-02-22 13:59 ` [Qemu-devel] [patch uq/master 2/2] kvm-all.c: define smp_wmb and use it for coalesced mmio Marcelo Tosatti
2010-02-22 14:23 ` [Qemu-devel] " Avi Kivity
2010-02-22 14:45 ` Marcelo Tosatti
2010-02-22 14:57 ` Avi Kivity
2010-02-22 14:57 ` Michael S. Tsirkin
2010-02-22 15:08 ` Avi Kivity
2010-02-22 15:08 ` Michael S. Tsirkin
2010-02-22 15:28 ` Avi Kivity
2010-02-22 14:44 ` Michael S. Tsirkin
2010-02-22 16:57 ` Marcelo Tosatti
2010-02-22 17:04 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100312024808.111854028@redhat.com \
--to=mtosatti@redhat.com \
--cc=amit.shah@redhat.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).