From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Npxq6-0002Qa-0T
	for qemu-devel@nongnu.org; Fri, 12 Mar 2010 00:55:14 -0500
Received: from [199.232.76.173] (port=40196 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Npxq5-0002Pp-8E
	for qemu-devel@nongnu.org; Fri, 12 Mar 2010 00:55:13 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <amit.shah@redhat.com>) id 1Npxq4-0003KV-29
	for qemu-devel@nongnu.org; Fri, 12 Mar 2010 00:55:13 -0500
Received: from mx1.redhat.com ([209.132.183.28]:18289)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <amit.shah@redhat.com>) id 1Npxq3-0003KP-MF
	for qemu-devel@nongnu.org; Fri, 12 Mar 2010 00:55:11 -0500
Date: Fri, 12 Mar 2010 11:23:43 +0530
From: Amit Shah <amit.shah@redhat.com>
Message-ID: <20100312055343.GA19703@amit-x200.redhat.com>
References: <20100312024549.787893344@redhat.com>
	<20100312024808.300129379@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20100312024808.300129379@redhat.com>
Subject: [Qemu-devel] Re: [patch 2/2] virtio-serial-bus: wake up iothread
	upon guest read notification
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, avi@redhat.com

On (Thu) Mar 11 2010 [23:45:51], Marcelo Tosatti wrote:
> Wake up iothread when buffers are consumed.
> 
> Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
> 
> Index: qemu-ioworker/hw/virtio-serial-bus.c
> ===================================================================
> --- qemu-ioworker.orig/hw/virtio-serial-bus.c
> +++ qemu-ioworker/hw/virtio-serial-bus.c
> @@ -331,6 +331,7 @@ static void handle_output(VirtIODevice *
>  
>  static void handle_input(VirtIODevice *vdev, VirtQueue *vq)
>  {
> +    qemu_notify_event(main_io_worker);
>  }

ACK, the host lets us know buffers are consumed and new buffers have
been added to the pool so that we can start sending more data.

Before this patch my tests took 16m18s to run.
After this patch my tests take 1m17s to run.

Both tests done with just one buffer made available in the virtio-queues.

		Amit