qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Andrea Arcangeli <aarcange@redhat.com>
To: Paul Brook <paul@codesourcery.com>
Cc: qemu-devel@nongnu.org, Avi Kivity <avi@redhat.com>
Subject: Re: [Qemu-devel] [PATCH QEMU] transparent hugepage support
Date: Fri, 12 Mar 2010 19:36:15 +0100	[thread overview]
Message-ID: <20100312183615.GW5677@random.random> (raw)
In-Reply-To: <201003121817.05524.paul@codesourcery.com>

On Fri, Mar 12, 2010 at 06:17:05PM +0000, Paul Brook wrote:
> > > No particular preference. Or you could have .../page_sizes list all
> > > available sizes, and have qemu take the first one (or last depending on
> > > sort order).
> > 
> > That would also work. Considering that the current transparent
> > hugepage support won't support any more than 1 page, I think it's ok
> > to call it hpage_size, the fact that amd/intel will add a 64k page
> > size is purely hypothetical
> 
> It's only hypothetical on x86. Many other architectures already support this 
> (at least ARM, MIPS, IA64, SPARC).

Hmm the kernel won't support mixed page size right now but ok this is
irrelevant because the API should stand. I think we'll be lucky enough
if 1 HPAGE size will be supported...

ia64 won't be able to take advantage of it either because it can't mix
different page sizes in the same vma, which is a requirement for
transparency and fallback to regular page size.

My point is that there is no need to show the smaller page sizes to
userland, only the max one is relevant and this isn't going to change
and I'm uncomfortable to add plural stuff to a patch that doesn't
contemplate mixes page sizes and for the time being multiple hpage size
isn't even on the horizon... I hate APIs...

What if we defer this whole issue and we just align on 2M if
/sys/kernel/mm/transparent_hugepage exists without checking /sys? ;)
If there's a way to define the host hpage size that will be enough, 2M
is there since PAE was introduced and it's not going to change
overnight so there's plenty of time later to add a hpage_sizes..

  reply	other threads:[~2010-03-12 18:36 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-11 15:14 [Qemu-devel] [PATCH QEMU] transparent hugepage support Andrea Arcangeli
2010-03-11 15:52 ` Avi Kivity
2010-03-11 16:05   ` Andrea Arcangeli
2010-03-13  8:28     ` Avi Kivity
2010-03-13 17:47       ` Andrea Arcangeli
2010-03-11 16:28   ` Paul Brook
2010-03-11 16:46     ` Andrea Arcangeli
2010-03-11 17:55       ` Paul Brook
2010-03-11 18:49         ` Andrea Arcangeli
2010-03-12 11:36           ` Paul Brook
2010-03-12 14:52             ` Andrea Arcangeli
2010-03-12 16:04               ` Paul Brook
2010-03-12 16:17                 ` Andrea Arcangeli
2010-03-12 16:24                   ` Paul Brook
2010-03-12 16:57                     ` Andrea Arcangeli
2010-03-12 17:10                       ` Paul Brook
2010-03-12 17:41                         ` Andrea Arcangeli
2010-03-12 18:17                           ` Paul Brook
2010-03-12 18:36                             ` Andrea Arcangeli [this message]
2010-03-12 18:41                               ` Paul Brook
2010-03-12 18:51                                 ` Andrea Arcangeli
2010-03-12 22:40                                   ` Jamie Lokier
2010-03-12 16:10               ` Paul Brook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100312183615.GW5677@random.random \
    --to=aarcange@redhat.com \
    --cc=avi@redhat.com \
    --cc=paul@codesourcery.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).