[Qemu-devel] Re: [PATCH 16/50] error: Replace qemu_error() by error_report()

[Luiz Capitulino <lcapitulino@redhat.com>]

On Thu,  4 Mar 2010 16:56:37 +0100
Markus Armbruster <armbru@redhat.com> wrote:

> error_report() terminates the message with a newline.  Strip it it
> from its arguments.
> 
> This fixes a few error messages lacking a newline:
> net_handle_fd_param()'s "No file descriptor named %s found", and
> tap_open()'s "vnet_hdr=1 requested, but no kernel support for
> IFF_VNET_HDR available" (all three versions).
> 
> There's one place that passes arguments without newlines
> intentionally: load_vmstate().  Fix it up.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>

 I'm starting to queue QMP related patches, so that we test them early,
and this one doesn't apply anymore against HEAD. Didn't investigate much,
though.

 If you decide to rebase, remember that we have patches from Shahar
that modify qerror.[hc], my queue is at:

git://repo.or.cz/qemu/qmp-unstable.git (master)