From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NqHBM-00028Z-DE
	for qemu-devel@nongnu.org; Fri, 12 Mar 2010 21:34:28 -0500
Received: from [199.232.76.173] (port=48975 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NqHBM-00028K-3p
	for qemu-devel@nongnu.org; Fri, 12 Mar 2010 21:34:28 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <lcapitulino@redhat.com>) id 1NqHBL-0007pg-2P
	for qemu-devel@nongnu.org; Fri, 12 Mar 2010 21:34:28 -0500
Received: from mx1.redhat.com ([209.132.183.28]:62641)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <lcapitulino@redhat.com>) id 1NqHBK-0007pa-Br
	for qemu-devel@nongnu.org; Fri, 12 Mar 2010 21:34:26 -0500
Received: from int-mx05.intmail.prod.int.phx2.redhat.com
	(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o2D2YNRV003668
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 12 Mar 2010 21:34:23 -0500
Date: Fri, 12 Mar 2010 23:34:14 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20100312233414.40c241c2@redhat.com>
In-Reply-To: <1267718231-13303-17-git-send-email-armbru@redhat.com>
References: <1267718231-13303-1-git-send-email-armbru@redhat.com>
	<1267718231-13303-17-git-send-email-armbru@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 16/50] error: Replace qemu_error() by
	error_report()
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org

On Thu,  4 Mar 2010 16:56:37 +0100
Markus Armbruster <armbru@redhat.com> wrote:

> error_report() terminates the message with a newline.  Strip it it
> from its arguments.
> 
> This fixes a few error messages lacking a newline:
> net_handle_fd_param()'s "No file descriptor named %s found", and
> tap_open()'s "vnet_hdr=1 requested, but no kernel support for
> IFF_VNET_HDR available" (all three versions).
> 
> There's one place that passes arguments without newlines
> intentionally: load_vmstate().  Fix it up.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>

 I'm starting to queue QMP related patches, so that we test them early,
and this one doesn't apply anymore against HEAD. Didn't investigate much,
though.

 If you decide to rebase, remember that we have patches from Shahar
that modify qerror.[hc], my queue is at:

git://repo.or.cz/qemu/qmp-unstable.git (master)