From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NqEsu-0003wD-IA for qemu-devel@nongnu.org; Fri, 12 Mar 2010 19:07:16 -0500 Received: from [199.232.76.173] (port=35134 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NqEsu-0003vu-6o for qemu-devel@nongnu.org; Fri, 12 Mar 2010 19:07:16 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NqEss-0001u7-FP for qemu-devel@nongnu.org; Fri, 12 Mar 2010 19:07:15 -0500 Received: from mail2.shareable.org ([80.68.89.115]:41711) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NqEsq-0001tj-VE for qemu-devel@nongnu.org; Fri, 12 Mar 2010 19:07:14 -0500 Date: Sat, 13 Mar 2010 00:06:53 +0000 From: Jamie Lokier Subject: Re: [Qemu-devel] [PATCH 13/13] x86/cpuid: Update qemu64/32 CPU models Message-ID: <20100313000653.GI6491@shareable.org> References: <1268314747-11111-1-git-send-email-andre.przywara@amd.com> <1268314747-11111-14-git-send-email-andre.przywara@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1268314747-11111-14-git-send-email-andre.przywara@amd.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andre Przywara Cc: aurelien@aurel32.net, qemu-devel@nongnu.org Andre Przywara wrote: > Since we now have a real TCG feature set, use it to describe the > artificial qemu CPUs (both 64 and 32-bit). If new features are added > to TCG, the capability of qemu64/32 will automatically be adjusted. > > Signed-off-by: Andre Przywara > - .features = PPRO_FEATURES | > - /* these features are needed for Win64 and aren't fully implemented */ > - CPUID_MTRR | CPUID_CLFLUSH | CPUID_MCA | > - /* this feature is needed for Solaris and isn't fully implemented */ > - CPUID_PSE36, > - .ext_features = CPUID_EXT_SSE3 | CPUID_EXT_CX16 | CPUID_EXT_POPCNT, > - .ext2_features = (PPRO_FEATURES & EXT2_FEATURE_MASK) | > - CPUID_EXT2_LM | CPUID_EXT2_SYSCALL | CPUID_EXT2_NX, > - .ext3_features = CPUID_EXT3_LAHF_LM | CPUID_EXT3_SVM | > - CPUID_EXT3_ABM | CPUID_EXT3_SSE4A, Those comments seem to have disappeared. Are they useful - or even correct any more? > + .features = TCG_FEATURES, > + .ext_features = TCG_EXT_FEATURES, > + /* 3DNow! is deprecated, so leave it out of the default feature set */ > + .ext2_features = (TCG_EXT2_FEATURES | EXT2_FEATURES_64) & > + ~(CPUID_EXT2_3DNOW | CPUID_EXT2_3DNOWEXT), > + .ext3_features = TCG_EXT3_FEATURES, 3DNow! is an old capability, but why is that a reason to single it out for omission? Is there any harm in it being enabled? -- Jamie