From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NqHVk-0001Ik-OG for qemu-devel@nongnu.org; Fri, 12 Mar 2010 21:55:32 -0500 Received: from [199.232.76.173] (port=46246 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NqHVj-0001Ht-Ag for qemu-devel@nongnu.org; Fri, 12 Mar 2010 21:55:31 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NqHVi-0000Xe-HL for qemu-devel@nongnu.org; Fri, 12 Mar 2010 21:55:31 -0500 Received: from ey-out-1920.google.com ([74.125.78.147]:27518) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NqHVi-0000XY-91 for qemu-devel@nongnu.org; Fri, 12 Mar 2010 21:55:30 -0500 Received: by ey-out-1920.google.com with SMTP id 5so509862eyb.14 for ; Fri, 12 Mar 2010 18:55:28 -0800 (PST) Date: Sat, 13 Mar 2010 03:55:25 +0100 From: "Edgar E. Iglesias" Subject: Re: [Qemu-devel] [PATCH] CODING_STYLE: Reserve qemu_ prefix for library wrappers Message-ID: <20100313025525.GA27110@laped.iglesias.mooo.com> References: <4B98FA68.7000901@codemonkey.ws> <1268318923-13397-1-git-send-email-avi@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1268318923-13397-1-git-send-email-avi@redhat.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: qemu-devel@nongnu.org On Thu, Mar 11, 2010 at 04:48:43PM +0200, Avi Kivity wrote: > Signed-off-by: Avi Kivity > --- > CODING_STYLE | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/CODING_STYLE b/CODING_STYLE > index a579cb1..92036f3 100644 > --- a/CODING_STYLE > +++ b/CODING_STYLE > @@ -49,6 +49,9 @@ and is therefore likely to be changed. > Typedefs are used to eliminate the redundant 'struct' keyword. It is the > QEMU coding style. > > +When wrapping standard library functions, use the prefix qemu_ to alert > +readers that they are seeing a wrapped version; otherwise avoid this prefix. > + > 4. Block structure > > Every indented statement is braced; even if the block contains just one Not sure what "standard library functions" includes but I think the qemu prefix should be allowed whenever one needs to wrap external code blocks into qemu. I don't feel very strongly about this though. I can call my stuff wrap_xxx if I need to :) Cheers, Edde