From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NqpTo-00041h-Fp for qemu-devel@nongnu.org; Sun, 14 Mar 2010 11:11:48 -0400 Received: from [199.232.76.173] (port=52167 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NqpTn-000419-U0 for qemu-devel@nongnu.org; Sun, 14 Mar 2010 11:11:47 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NqpTn-0006nE-BD for qemu-devel@nongnu.org; Sun, 14 Mar 2010 11:11:47 -0400 Received: from mx20.gnu.org ([199.232.41.8]:20330) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NqpTn-0006nA-3q for qemu-devel@nongnu.org; Sun, 14 Mar 2010 11:11:47 -0400 Received: from mail.codesourcery.com ([38.113.113.100]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NqpTm-0001Hf-BH for qemu-devel@nongnu.org; Sun, 14 Mar 2010 11:11:46 -0400 From: Paul Brook Date: Sun, 14 Mar 2010 15:11:30 +0000 References: <201003130045.22664.paul@codesourcery.com> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201003141511.31253.paul@codesourcery.com> Subject: [Qemu-devel] Re: linux-user issues List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: malc Cc: qemu-devel@nongnu.org, Aurelien Jarno > On Sat, 13 Mar 2010, Paul Brook wrote: > > > a) elfload.c:859 > > > > > > #define TARGET_ELF_PAGESTART(_v) ((_v) & ~(unsigned > > > long)(TARGET_ELF_EXEC_PAGESIZE-1)) > > > > > > This means that for 64bit guest on a 32bit host the _v's value is > > > silently reduced to 32bit, the cast should be abi_ulong. > > > > > > b) mmap.c:428 > > > > > > real_start = start & qemu_host_page_mask; > > > > > > Same thing basically qemu_host_page_mask is unsigned long and so > > > the upper bits are sliently cleared. Again qemu_host_page_mask > > > should probably be abi_ulong. > > > > > > The above two make elf binary with one of the segments above 4G load > > > and run on 32bit guest only to fail well into execution and without > > > any indication that it shouldn't have been allowed to run in the first > > > place. > > > > I'd be amazed if these are the only two issues, and expect 64-bit guests > > on 32-bit hosts to be generally unsafe. > > These are the two issues i've been bitten by while trying to solve > x86_64's far jumps, if you are okay with code silently misbehaving > fine by me. I never said this was ok behavior. Only that you've probably only discovered the tip of the iceberg. Paul