From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nqw7o-0007bT-Rv for qemu-devel@nongnu.org; Sun, 14 Mar 2010 18:17:32 -0400 Received: from [199.232.76.173] (port=59139 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nqw7o-0007bF-Db for qemu-devel@nongnu.org; Sun, 14 Mar 2010 18:17:32 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1Nqw7n-0006iv-0j for qemu-devel@nongnu.org; Sun, 14 Mar 2010 18:17:32 -0400 Received: from hall.aurel32.net ([88.191.82.174]:43470) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Nqw7m-0006in-LJ for qemu-devel@nongnu.org; Sun, 14 Mar 2010 18:17:30 -0400 Date: Sun, 14 Mar 2010 23:17:27 +0100 From: Aurelien Jarno Subject: Re: [Qemu-devel] [PATCH] load_elf: replace the address addend by a translation function Message-ID: <20100314221727.GG2381@hall.aurel32.net> References: <1268600220-29293-1-git-send-email-aurelien@aurel32.net> <201003142159.45411.paul@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <201003142159.45411.paul@codesourcery.com> Sender: Aurelien Jarno List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Brook Cc: qemu-devel@nongnu.org Thanks for the review. On Sun, Mar 14, 2010 at 09:59:44PM +0000, Paul Brook wrote: > > The patch also convert all machines that have an addend, simplify the > > PowerPC kernel loading > > The new PPC code looks like it may break images > 16M in size. The idea was to get rid of the most significant byte, as it changes depending on the kernel version, while we want the kernel to be loaded at a fixed address. Looks like I have to shift the mask by four bits. > > and fix the MIPS kernel loading using this new > > feature. > > I'm fairly sure the MIPS routines are not board specific, so it'd be nice if > we could avoid the duplication. This would also reduce pain if we implement > loading to other segments (in particular kseg1 and xkphys). > Good idea. -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net