From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nqx0J-0007Tb-Nk for qemu-devel@nongnu.org; Sun, 14 Mar 2010 19:13:51 -0400 Received: from [199.232.76.173] (port=44194 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nqx0J-0007TG-DZ for qemu-devel@nongnu.org; Sun, 14 Mar 2010 19:13:51 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1Nqx0I-00017b-5y for qemu-devel@nongnu.org; Sun, 14 Mar 2010 19:13:51 -0400 Received: from hall.aurel32.net ([88.191.82.174]:42249) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Nqx0H-00017V-Qs for qemu-devel@nongnu.org; Sun, 14 Mar 2010 19:13:50 -0400 Date: Mon, 15 Mar 2010 00:13:47 +0100 From: Aurelien Jarno Subject: Re: [Qemu-devel] [PATCH] load_elf: replace the address addend by a translation function Message-ID: <20100314231347.GI2381@hall.aurel32.net> References: <1268600220-29293-1-git-send-email-aurelien@aurel32.net> <201003142159.45411.paul@codesourcery.com> <20100314221727.GG2381@hall.aurel32.net> <201003142255.48323.paul@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <201003142255.48323.paul@codesourcery.com> Sender: Aurelien Jarno List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Brook Cc: qemu-devel@nongnu.org On Sun, Mar 14, 2010 at 10:55:48PM +0000, Paul Brook wrote: > > Thanks for the review. > > > > On Sun, Mar 14, 2010 at 09:59:44PM +0000, Paul Brook wrote: > > > > The patch also convert all machines that have an addend, simplify the > > > > PowerPC kernel loading > > > > > > The new PPC code looks like it may break images > 16M in size. > > > > The idea was to get rid of the most significant byte, as it changes > > depending on the kernel version, while we want the kernel to be loaded > > at a fixed address. Looks like I have to shift the mask by four bits. > > I thought that problem was that some kernels are (incorrectly) linked with > LMA==VMA, whereas they should have a base load address of zero. > Yes, this is the problem. But the way to workaround it is to get rid of the MSB. -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net