From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NrAWy-000441-13 for qemu-devel@nongnu.org; Mon, 15 Mar 2010 09:40:28 -0400 Received: from [199.232.76.173] (port=49322 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NrAWx-00043q-K9 for qemu-devel@nongnu.org; Mon, 15 Mar 2010 09:40:27 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NrAWw-0002m6-4f for qemu-devel@nongnu.org; Mon, 15 Mar 2010 09:40:27 -0400 Received: from mx20.gnu.org ([199.232.41.8]:34982) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NrAWv-0002l3-PH for qemu-devel@nongnu.org; Mon, 15 Mar 2010 09:40:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NrAWu-0000qB-6n for qemu-devel@nongnu.org; Mon, 15 Mar 2010 09:40:24 -0400 Date: Mon, 15 Mar 2010 15:36:51 +0200 From: "Michael S. Tsirkin" Message-ID: <20100315133650.GA31573@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Subject: [Qemu-devel] [PATCH] pcnet: make subsystem vendor id match hardware List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann , Blue Swirl , Jan Kiszka , Anthony Liguori Cc: qemu-devel@nongnu.org Real pcnet device (AT2450) apparently has subsystem device and vendor id set to 0, this is out of spec (which requires that vendor id is obtained from PCI SIG) but windows xp driver seems to need this in order to associate. qemu sets pci subsystem id to qumranet/qemu since d350d97d196a632b6c7493acf07a061017fc6f7d, debian does not yet have this patch. https://bugzilla.redhat.com/show_bug.cgi?id=521247 Signed-off-by: Michael S. Tsirkin Cc: Gerd Hoffmann Cc: Anthony Liguori --- hw/pcnet.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/hw/pcnet.c b/hw/pcnet.c index 44b5b31..12260be 100644 --- a/hw/pcnet.c +++ b/hw/pcnet.c @@ -1997,6 +1997,9 @@ static int pci_pcnet_init(PCIDevice *pci_dev) pci_set_long(pci_conf + PCI_BASE_ADDRESS_0 + 4, PCI_BASE_ADDRESS_SPACE_MEMORY); + pci_set_word(pci_conf + PCI_SUBSYSTEM_VENDOR_ID, 0x0); + pci_set_word(pci_conf + PCI_SUBSYSTEM_ID, 0x0); + /* TODO: value must be 0 at RST# */ pci_conf[PCI_INTERRUPT_PIN] = 1; // interrupt pin 0 pci_conf[PCI_MIN_GNT] = 0x06; -- 1.7.0.18.g0d53a5