From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NrqjG-0007YH-G3 for qemu-devel@nongnu.org; Wed, 17 Mar 2010 06:43:58 -0400 Received: from [199.232.76.173] (port=35572 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NrqjG-0007Y7-6g for qemu-devel@nongnu.org; Wed, 17 Mar 2010 06:43:58 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NrqjF-00006m-34 for qemu-devel@nongnu.org; Wed, 17 Mar 2010 06:43:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:6481) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NrqjE-00006e-MX for qemu-devel@nongnu.org; Wed, 17 Mar 2010 06:43:56 -0400 Date: Wed, 17 Mar 2010 12:40:28 +0200 From: "Michael S. Tsirkin" Message-ID: <20100317104028.GA10425@redhat.com> References: <516a1529d5a7dbff8f1a83b12e068d6afca2062f.1268758544.git.mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: [Qemu-devel] Re: [PATCHv5 11/11] virtio-net: vhost net support List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: amit.shah@redhat.com, qemu-devel@nongnu.org, kraxel@redhat.com On Tue, Mar 16, 2010 at 07:57:51PM +0100, Juan Quintela wrote: > "Michael S. Tsirkin" wrote: > > This connects virtio-net to vhost net backend. > > The code is structured in a way analogous to what we have with vnet > > header capability in tap. > > > > We start/stop backend on driver start/stop as > > well as on save and vm start (for migration). > > > > > + uint8_t vhost_started; > > > I didn't noticed the 1st time. vhost_started looks like a bool :p > > Later, Juan. Yes. I have no idea why, but the surrounding code has a lot of flags all of which are uint8_t, so I followed suit. -- MST