qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Andrea Arcangeli <aarcange@redhat.com>
To: Paul Brook <paul@codesourcery.com>
Cc: qemu-devel@nongnu.org, Avi Kivity <avi@redhat.com>
Subject: Re: [Qemu-devel] [PATCH QEMU] Transparent Hugepage Support #3
Date: Wed, 17 Mar 2010 16:55:42 +0100	[thread overview]
Message-ID: <20100317155542.GE5752@random.random> (raw)
In-Reply-To: <201003171552.15230.paul@codesourcery.com>

On Wed, Mar 17, 2010 at 03:52:15PM +0000, Paul Brook wrote:
> > > > Size not multiple I think is legitimate, the below-4G chunk isn't
> > > > required to end 2M aligned, all it matters is that the above-4G then
> > > > starts aligned. In short one thing to add in the future as parameter
> > > > to qemu_ram_alloc is the physical address that the host virtual
> > > > address corresponds to.
> > >
> > > In general you don't know this at allocation time.
> > 
> > Caller knows it, it's not like the caller is outside of qemu, it's not
> > some library. We know this is enough with the caller that there is now.
> 
> No we don't.  As discussed previously, there are machines where the physical 
> location of RAM is configurable at runtime.  In fact it's common for the ram 
> to be completely absent at reset.

This is why PREFERRED_RAM_ALIGN is only defined for __x86_64__. I'm
not talking about other archs that may never support transparent
hugepages in the kernel because of other architectural constrains that
may prevent to map hugepages mixed with regular pages in the same vma.

  reply	other threads:[~2010-03-17 15:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-17 14:59 [Qemu-devel] [PATCH QEMU] Transparent Hugepage Support #3 Andrea Arcangeli
2010-03-17 15:05 ` Paul Brook
2010-03-17 15:14   ` Andrea Arcangeli
2010-03-17 15:21     ` Paul Brook
2010-03-17 15:35       ` Andrea Arcangeli
2010-03-17 15:52         ` Paul Brook
2010-03-17 15:55           ` Andrea Arcangeli [this message]
2010-03-17 16:07             ` Paul Brook
2010-03-17 16:23               ` Andrea Arcangeli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100317155542.GE5752@random.random \
    --to=aarcange@redhat.com \
    --cc=avi@redhat.com \
    --cc=paul@codesourcery.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).