From: Luiz Capitulino <lcapitulino@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH 2/6] error: Trim includes in qerror.c
Date: Thu, 18 Mar 2010 18:32:03 -0300 [thread overview]
Message-ID: <20100318183203.1f8dbe81@redhat.com> (raw)
In-Reply-To: <1268848614-6844-3-git-send-email-armbru@redhat.com>
On Wed, 17 Mar 2010 18:56:50 +0100
Markus Armbruster <armbru@redhat.com> wrote:
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> qerror.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/qerror.c b/qerror.c
> index d0aba61..ff2fbd5 100644
> --- a/qerror.c
> +++ b/qerror.c
> @@ -11,9 +11,7 @@
> */
> #include "qjson.h"
> #include "qerror.h"
> -#include "qstring.h"
> #include "qemu-common.h"
> -#include "qemu-error.h"
Care to explain the reason? Are you relaying on the includes in qjson.h?
>
> static void qerror_destroy_obj(QObject *obj);
>
next prev parent reply other threads:[~2010-03-18 21:32 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-17 17:56 [Qemu-devel] [PATCH 0/6] error: Clean up after recent changes Markus Armbruster
2010-03-17 17:56 ` [Qemu-devel] [PATCH 1/6] error: Trim includes after "Move qemu_error & friends..." Markus Armbruster
2010-03-18 21:30 ` [Qemu-devel] " Luiz Capitulino
2010-03-19 21:31 ` Markus Armbruster
2010-03-22 0:40 ` Luiz Capitulino
2010-03-22 8:38 ` Markus Armbruster
2010-03-17 17:56 ` [Qemu-devel] [PATCH 2/6] error: Trim includes in qerror.c Markus Armbruster
2010-03-18 21:32 ` Luiz Capitulino [this message]
2010-03-19 21:33 ` [Qemu-devel] " Markus Armbruster
2010-03-22 0:38 ` Luiz Capitulino
2010-03-17 17:56 ` [Qemu-devel] [PATCH 3/6] error: Trim includes after "Infrastructure to track locations..." Markus Armbruster
2010-03-17 17:56 ` [Qemu-devel] [PATCH 4/6] error: Make use of error_set_progname() optional Markus Armbruster
2010-03-17 17:56 ` [Qemu-devel] [PATCH 5/6] error: Link qemu-img, qemu-nbd, qemu-io with qemu-error.o Markus Armbruster
2010-03-17 19:53 ` Blue Swirl
2010-03-17 21:17 ` Markus Armbruster
2010-03-18 17:58 ` Blue Swirl
2010-03-18 18:09 ` Markus Armbruster
2010-03-18 18:20 ` Blue Swirl
2010-03-18 18:55 ` Markus Armbruster
2010-03-18 19:32 ` Blue Swirl
2010-03-22 9:37 ` Markus Armbruster
2010-03-17 17:56 ` [Qemu-devel] [PATCH 6/6] error: Move qerror_report() from qemu-error.[ch] to qerror.[ch] Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100318183203.1f8dbe81@redhat.com \
--to=lcapitulino@redhat.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).