From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NsiC0-0003VT-G9 for qemu-devel@nongnu.org; Fri, 19 Mar 2010 15:49:12 -0400 Received: from [199.232.76.173] (port=33692 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NsiBz-0003VI-Fh for qemu-devel@nongnu.org; Fri, 19 Mar 2010 15:49:11 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NsiBx-0000CO-Qv for qemu-devel@nongnu.org; Fri, 19 Mar 2010 15:49:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44778) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NsiBx-0000CC-FR for qemu-devel@nongnu.org; Fri, 19 Mar 2010 15:49:09 -0400 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o2JJn6ut031677 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 19 Mar 2010 15:49:06 -0400 Date: Fri, 19 Mar 2010 16:48:59 -0300 From: Luiz Capitulino Message-ID: <20100319164859.3f58c667@redhat.com> In-Reply-To: <1268929996-28763-1-git-send-email-armbru@redhat.com> References: <1268929996-28763-1-git-send-email-armbru@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 00/11] monitor: New commands netdev_add, netdev_del List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org On Thu, 18 Mar 2010 17:33:07 +0100 Markus Armbruster wrote: I'm getting the following build error: """ qemu-option.o: In function `parse_option_bool': /home/lcapitulino/src/qmp-unstable/qemu-option.c:179: undefined reference to `qerror_report_internal' qemu-option.o: In function `parse_option_number': /home/lcapitulino/src/qmp-unstable/qemu-option.c:196: undefined reference to `qerror_report_internal' /home/lcapitulino/src/qmp-unstable/qemu-option.c:201: undefined reference to `qerror_report_internal' qemu-option.o: In function `parse_option_size': /home/lcapitulino/src/qmp-unstable/qemu-option.c:229: undefined reference to `qerror_report_internal' /home/lcapitulino/src/qmp-unstable/qemu-option.c:233: undefined reference to `qerror_report_internal' qemu-option.o:/home/lcapitulino/src/qmp-unstable/qemu-option.c:582: more undefined references to `qerror_report_internal' follow collect2: ld returned 1 exit status make: *** [qemu-nbd] Error 1 """ Adding a qerror_report_internal() entry in qemu-tool.c fixes it. > Markus Armbruster (11): > error: Put error definitions back in alphabetical order > error: New QERR_DUPLICATE_ID > error: Convert qemu_opts_create() to QError > error: New QERR_INVALID_PARAMETER_VALUE > error: Convert qemu_opts_set() to QError > error: Drop extra messages after qemu_opts_set() and > qemu_opts_parse() > error: Use QERR_INVALID_PARAMETER_VALUE instead of > QERR_INVALID_PARAMETER > error: Convert qemu_opts_validate() to QError > error: Convert net_client_init() to QError > error: New QERR_DEVICE_IN_USE > monitor: New commands netdev_add, netdev_del > > hw/pci-hotplug.c | 2 - > hw/qdev.c | 2 +- > monitor.c | 6 ++- > net.c | 95 +++++++++++++++++++++++++++++++++++++++++------------ > net.h | 2 + > qemu-config.c | 1 - > qemu-monitor.hx | 30 +++++++++++++++++ > qemu-option.c | 24 +++++-------- > qerror.c | 20 ++++++++++- > qerror.h | 17 ++++++++-- > vl.c | 5 --- > 11 files changed, 151 insertions(+), 53 deletions(-) >