From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Nt1aw-0006Xx-8j
	for qemu-devel@nongnu.org; Sat, 20 Mar 2010 12:32:14 -0400
Received: from [199.232.76.173] (port=49577 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Nt1av-0006XX-HE
	for qemu-devel@nongnu.org; Sat, 20 Mar 2010 12:32:13 -0400
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <hch@lst.de>) id 1Nt1as-0002Zn-W9
	for qemu-devel@nongnu.org; Sat, 20 Mar 2010 12:32:13 -0400
Received: from verein.lst.de ([213.95.11.210]:57259)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60)
	(envelope-from <hch@lst.de>) id 1Nt1as-0002ZP-1A
	for qemu-devel@nongnu.org; Sat, 20 Mar 2010 12:32:10 -0400
Date: Sat, 20 Mar 2010 17:32:00 +0100
From: Christoph Hellwig <hch@lst.de>
Subject: Re: [Qemu-devel] NetBSD qemu block device support
Message-ID: <20100320163200.GA9159@lst.de>
References: <70f06bad1003170559u1d5ab0b0jad069cf0c336aa5a@mail.gmail.com>
	<f43fc5581003181332n2a3dea2bs85a8e91be4b8beb8@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f43fc5581003181332n2a3dea2bs85a8e91be4b8beb8@mail.gmail.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: haad <haad@netbsd.org>, qemu-devel@nongnu.org

On Thu, Mar 18, 2010 at 10:32:36PM +0200, Blue Swirl wrote:
> The patch does not apply to current development repository.
> 
> There is no description of the change suitable for changelog without
> any editing.
> 
> Signed-off-by: line is missing.
> 
> The patch combines formatting (whitespace) changes with functional
> changes. The formatting changes seem useless.
> 
> The essence of the patch is twofold, It adds NetBSD specific includes
> and NetBSD specific code to raw_getlength(). These look OK, except
> formatting may be a bit off (no space after if) and currently the code
> probably should be surrounded by
> #ifdef DIOCGWEDGEINFO
> #endif
> or just #ifdef __NetBSD__.

Also given the extreme mess that raw_getlength is I would much prefer
to give every new OS it's own copy of it, similar to how we already
handle OpenBSD today.